Consolidate extension type registration - #19938
Closed
brandon-b-miller wants to merge 3 commits into
Closed
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
I'm going to close this out since we're designing #22884 the right way from the ground up for numba-cuda-mlir and that will eventually replace this approach altogether. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of investigating #627 and #18868 I moved some code around to make it easier to profile as well as import things in a more natural order. The following is a summary of the changes:
compile_udf, the only function needed by both the UDF extension framework and the rest of cuDF as well (aggregations, df.query, etc) to a common area with minimal dependencies. This avoids aggregation needing to import the entire extension framework and delays registering the extensions until we hit the groupby part of the import treemasked_typing.pyandmasked_lowering.py. This is the high level "scalar" object with a dtype and a null in our UDFs, so it should import what it needs to know about strings fromstrings_typing.pyandstrings_lowering.py. This is as opposed to current state where the strings code imports the masked code to define the operations on nullable strings.The motivation of this PR is to put all the numba extension setup work under one function name so it's easier to make sense of how long things are taking at import.