Skip to content

JNI Set RMM_LOG_LEVEL and RMM_LOG_ACTIVE_LEVEL to allow setting log level at compile time #19435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 2 commits into from
Jul 24, 2025
Merged

JNI Set RMM_LOG_LEVEL and RMM_LOG_ACTIVE_LEVEL to allow setting log level at compile time #19435

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cec8547
JNI Set RMM_LOG_LEVEL and RMM_LOG_ACTIVE_LEVEL to allow setting log e…
abellina Jul 18, 2025
df05035
Merge branch 'branch-25.08' into set_rmm_log_level
abellina Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions java/src/main/native/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,18 @@ if(USE_GDS)
endif()
endif()

# Set RMM logging level
set(RMM_LOGGING_LEVEL

@bdice bdice Jul 18, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyasr Is this the correct way to use rapids-logger? I discussed a bit with @abellina offline but I don't know the proper way to solve this problem.

@bdice bdice Jul 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a related conversation here about what should be precompiled in RMM here: rapidsai/rmm#1983 (comment)

It feels like these two topics might be solvable in similar ways.

@vyasr vyasr Jul 21, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming rmm is still being from source as part of the build, this will work, yes. It won't have any effect if you are using precompiled binaries, but since Spark doesn't do that this seems fine. The actual logs observed at runtime may still require setting the runtime log level if the logging functions are used.

"INFO"
CACHE STRING "Choose the logging level."
)
set_property(
CACHE RMM_LOGGING_LEVEL PROPERTY STRINGS "TRACE" "DEBUG" "INFO" "WARN" "ERROR" "CRITICAL" "OFF"
)
message(VERBOSE "CUDF_JNI: RMM_LOGGING_LEVEL = '${RMM_LOGGING_LEVEL}'.")

add_compile_definitions("RMM_LOG_ACTIVE_LEVEL=RAPIDS_LOGGER_LOG_LEVEL_${RMM_LOGGING_LEVEL}")

# ##################################################################################################
# * library targets -------------------------------------------------------------------------------

Expand Down