Skip to content

Update to dlpack 1.x - #19383

Closed
bdice wants to merge 3 commits into
NVIDIA:branch-25.08from
bdice:dlpack-1.x
Closed

Update to dlpack 1.x#19383
bdice wants to merge 3 commits into
NVIDIA:branch-25.08from
bdice:dlpack-1.x

Conversation

@bdice

@bdice bdice commented Jul 15, 2025

Copy link
Copy Markdown
Contributor

Description

This PR updates cudf to use dlpack 1.x. See release notes:

There's no specific motivation for this update, but it seems appropriate for us to use the stable major version now that it has been out for almost a year.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-bot Bot commented Jul 15, 2025

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Jul 15, 2025
@bdice

bdice commented Jul 15, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test 0b108b9

@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 15, 2025
@vyasr

vyasr commented Jul 15, 2025

Copy link
Copy Markdown
Contributor

Please coordinate any updates here with @seberg

@bdice

bdice commented Jul 15, 2025

Copy link
Copy Markdown
Contributor Author

Thanks. Seems like #18566 was started with work in the same direction. I wasn't planning to do C++/Python changes, just update the dependency. I'll let @seberg weigh in.

@bdice

bdice commented Jul 15, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test 12aca36

@seberg

seberg commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

Ah, I should pick up that PR again soon, but doesn't hurt to update this dependency. FWIW, dlpack must be ABI stable to be useful (and currently is), so I think it would be OK to use >=0.8 to not restrict things unnecessarily.

@bdice

bdice commented Jul 25, 2025

Copy link
Copy Markdown
Contributor Author

@seberg I'll close this and let you work on #18566.

@bdice bdice closed this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants