Repository navigation
Support constructing pylibcudf Columns and Tables from views into arbitrary objects #18314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rapids-bot
merged 9 commits into
NVIDIA:branch-25.06
from
vyasr:feat/plc_column_from_arbitrary
Mar 19, 2025
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3d13805
First version of function for creating column view from another object
vyasr 73942a8
Add link to Cython issue
vyasr 2f46a58
Revert inadvertent readonly change
vyasr b6189a7
Fix recursive call
vyasr 02076cc
Implement new table API
vyasr f2ed57f
Renaming and cleanup
vyasr e21a6c6
Use new function for contiguous split
vyasr 2152d70
Also apply the change to the unpack_from_memoryview function
vyasr ca60ead
Merge branch 'branch-25.06' into feat/plc_column_from_arbitrary
vyasr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,11 @@ | ||
| # Copyright (c) 2023, NVIDIA CORPORATION. | ||
| # Copyright (c) 2023-2025, NVIDIA CORPORATION. | ||
|
|
||
|
|
||
| cdef class gpumemoryview: | ||
| # TODO: Eventually probably want to make this opaque, but for now it's fine | ||
| # to treat this object as something like a POD struct | ||
| cdef readonly: | ||
| Py_ssize_t ptr | ||
| object obj | ||
| cdef readonly Py_ssize_t ptr | ||
| cdef readonly object obj | ||
|
|
||
| @staticmethod | ||
| cdef gpumemoryview from_pointer(Py_ssize_t ptr, object owner) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.