Revert "New Decimal <--> Floating conversion (#15905)" - #16283
Closed
ttnghia wants to merge 2 commits into
Closed
Conversation
This reverts commit 3c83ce4.
ttnghia
added
3 - Ready for Review
github-actions
Bot
added
Python
vyasr
approved these changes
Jul 15, 2024
vyasr
left a comment
vyasr
left a comment
Contributor
There was a problem hiding this comment.
Approving based on offline discussions indicating that we think it's safe to go ahead without rebenchmarking.
davidwendt
approved these changes
Jul 15, 2024
Contributor
Author
|
/merge |
Contributor
|
@ttnghia just wondering what we are waiting for in this PR. |
Contributor
Author
There seems to be another fix merged in cudf so this may no longer be needed. I'm still waiting for confirmation before closing this. |
|
This is the related perf fix PR: #16287. It's been merged, but still waiting for final confirmation that is fixed the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the PR #15905 merged, there was a performance regression reported:
This reverts the problematic PR (#15905), waiting for more investigation on the regression.