Skip to content

Remove temporary functor overloads required by cuco version bump - #16242

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-24.08from
PointKernel:remove-temporary-overloads
Jul 12, 2024
Merged

Remove temporary functor overloads required by cuco version bump#16242
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-24.08from
PointKernel:remove-temporary-overloads

Conversation

@PointKernel

Copy link
Copy Markdown
Member

Description

This is a follow-up of #15938. It removes the temporary workaround no longer needed after the cuco version bump.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change 3 - Ready for Review Ready for review by team labels Jul 10, 2024
@PointKernel
PointKernel marked this pull request as ready for review July 10, 2024 19:42
@PointKernel
PointKernel requested a review from a team as a code owner July 10, 2024 19:42
@PointKernel PointKernel self-assigned this Jul 10, 2024

@bdice bdice left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All negative PRs got me like

image

@PointKernel

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit 99ad73d into NVIDIA:branch-24.08 Jul 12, 2024
@PointKernel
PointKernel deleted the remove-temporary-overloads branch July 12, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants