Refactor from_arrow_device/host to use resource_ref - #16160
Merged
rapids-bot[bot] merged 4 commits intoJul 3, 2024
Merged
Conversation
pmattione-nvidia
approved these changes
Jul 2, 2024
davidwendt
approved these changes
Jul 2, 2024
vyasr
reviewed
Jul 2, 2024
vyasr
left a comment
Contributor
There was a problem hiding this comment.
My apologies, #15904 (which was based on the PRs adding the code that this fixed) proliferated the issue (and introduced the conflicts here). When resolving conflicts, could you fix the from_arrow_stream API as well? I'll be careful to correctly handle the mrs in future PRs.
vyasr
approved these changes
Jul 2, 2024
vyasr
reviewed
Jul 2, 2024
Contributor
Author
|
Can't see why the docs build is failing. Warnings only: |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16159
Also fixes typos / leftovers in dictionary
add_keyscopydocs.Checklist