Backport #16045 to 24.06 - #16102
Merged
raydouglass merged 3 commits intoJul 1, 2024
Merged
Conversation
Add test for AST cast-to-float64 Resolves NVIDIA#16023 Authors: - Paul Mattione (https://github.com/pmattione-nvidia) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Bradley Dice (https://github.com/bdice) URL: NVIDIA#16045
vyasr
added
bug
vyasr
marked this pull request as ready for review
June 26, 2024 17:09
vyasr
requested review from
davidwendt and
harrism
and removed request for
a team
June 26, 2024 17:09
3 tasks
Contributor
|
Was there supposed to be a code fix here? Perhaps this was for a cuco change. I'm not sure backporting a unit test is necessary. Are we concerned that possible future patches will break? |
Contributor
Author
Contributor
|
I favor backporting the test since it was missed in the original PR and provides a way to verify that the backported fix actually works in 24.06 (it was only tested in 24.08). I don’t have any specific concerns that it will fail, it is moreso a matter of completeness in addressing the reported bug in an easily verifiable way. |
bdice
approved these changes
Jul 1, 2024
davidwendt
approved these changes
Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backporting #16045 for a patch release.
Checklist