Repository navigation
Update implementations to build with the latest cuco #15938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
9bc27dd
547a9d2
2e169ee
4a59319
72c284c
d13afa2
7b3bd7e
419ab26
1a9832a
c7417ed
84cabba
ad1f935
62e0eae
78b16ba
6bd8e31
db6afeb
46757da
7fa64d5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -86,10 +86,18 @@ struct vocab_equal { | |
| return lhs == rhs; // all rows are expected to be unique | ||
| } | ||
| // used by find | ||
| // suppress "function was declared but never referenced warning" | ||
| #pragma nv_diagnostic push | ||
| #pragma nv_diag_suppress 177 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you put a comment here on what this is suppressing?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point. Comments added as requested. Once the cuco bump PR merged into |
||
| __device__ bool operator()(cudf::size_type lhs, cudf::string_view const& rhs) const noexcept | ||
| { | ||
| return d_strings.element<cudf::string_view>(lhs) == rhs; | ||
| } | ||
| __device__ bool operator()(cudf::string_view const& lhs, cudf::size_type rhs) const noexcept | ||
| { | ||
| return d_strings.element<cudf::string_view>(rhs) == lhs; | ||
| } | ||
| #pragma nv_diagnostic pop | ||
| }; | ||
|
|
||
| using probe_scheme = cuco::linear_probing<1, vocab_hasher>; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function was declared but never referencedmeans we never use these functions. Is this the correct diagnosis? If so can we remove these functions?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the intention is a bit obscure here.
Basically, all functions involved in this PR have two overloads: one is working with the current old cuco and the other will work with the upcoming new cuco. Only one of those two will be used at the same point thus the other is always redundant. I will remove redundant ones once we migrate to use the new cuco. The goal of this work is mainly to avoid breaks when
rapids-cmakefetches the new cuco but libcudf can only work with the old.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. Thank you.