[REVIEW] Pin protobuf version - #10996
Merged
Merged
Conversation
galipremsagar
added
3 - Ready for Review
ajschmidt8
approved these changes
May 27, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10996 +/- ##
================================================
+ Coverage 86.32% 86.54% +0.22%
================================================
Files 144 144
Lines 22688 23364 +676
================================================
+ Hits 19585 20220 +635
- Misses 3103 3144 +41
Continue to review full report at Codecov.
|
Contributor
Author
|
rerun tests |
Contributor
Author
|
rerun tests |
vyasr
added
4 - Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #10990
This PR pins the
protobufversion to the latest and chooses narrower pinning because of the lower likelihood of breaking API changes between minor patch versions as opposed to major version changes.