Add support for nvcomp-2.3 in java build - #10837
Closed
jbrennan333 wants to merge 5 commits into
Closed
jbrennan333 wants to merge 5 commits into
jbrennan333 wants to merge 5 commits into
Conversation
Contributor
Author
|
I tried using cmake install to do the copies with code like this: But cc: @robertmaynard |
jlowe
reviewed
May 12, 2022
Contributor
|
I have opened a PR to add |
Contributor
Author
|
I don't understand what that checkstyle issue is? |
Contributor
It's CMake formatting: You probably need to run |
Contributor
Author
|
These changes were pulled into #10851, so this draft PR can be closed. |
rapids-bot Bot
pushed a commit
that referenced
this pull request
May 25, 2022
When building cudf on x86_64 hardware we can enable the new pre-built nvcomp 2.3 binaries to leverage new compression codec support. Closes #10681 Closes #10837 Authors: - Robert Maynard (https://github.com/robertmaynard) - Jim Brennan (https://github.com/jbrennan333) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Jason Lowe (https://github.com/jlowe) - AJ Schmidt (https://github.com/ajschmidt8) - Jim Brennan (https://github.com/jbrennan333) - Vyas Ramasubramani (https://github.com/vyasr) URL: #10851
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10681.
Add support to the Java build to use nvcomp-2.3 instead of nvcomp-2.2. The main difference is that nvcomp-2.2 was included as a static library built by CUDF CPP while nvcomp-2.3 is only available as shared libraries that must be downloaded separately.
I'm putting this up as a draft pr so I can get feedback, and also because merging this without additional changes to pull in nvcomp-2.3 automatically in CUDF are needed. If we merge this without those changes, the java build will succeed, but java unit tests will fail and the resulting jars will not work. This is primarily because of the changes to the NativeDepsLoader, which will fail if it does not find the nvcomp-2.3 shared libs.
Note that @robertmaynard is working on rapids_cpm_nvcomp. Once that is available, we should be able to update the changes here and combine them with the changes needed in CUDF CPP so we can do everything in one PR.
The spark-rapids-jni project will also require a corresponding change. I will file PR in that project as well.
Another reason to hold off on making this change is that nvcomp-2.3 shared libs are not compiled with CUDA_API_PER_THREAD_DEFAULT_STREAM. This is a performance issue for spark-rapids - see previous issue: #9534