[REVIEW] CSV Reader: Fix a segfault when byte range aligns with a page - #1044
Merged
mjsamoht merged 6 commits intoFeb 27, 2019
Merged
Conversation
… not needed to correctly parse with this terminator. Fixes a segfault when map size alignes with a page.
j-ieong
suggested changes
Feb 26, 2019
Co-Authored-By: vuule <vukasin.milovanovic.87@gmail.com>
j-ieong
approved these changes
Feb 27, 2019
j-ieong
left a comment
Contributor
There was a problem hiding this comment.
You need to fix the typo in the PR title as well.
Contributor
Author
Fixed. |
mjsamoht
approved these changes
Feb 27, 2019
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rapidsai/dask-cudf#102
*When mapping the file, num_bytes is now updated to account for page padding in all cases.
*Add a test for the failing case.