Re-enable string split anchor fuzz test - #15381
Conversation
The cuDF Glushkov fast path no longer treats a lazy quantifier as greedy in split_re (NVIDIA/cudf#23381), and the fix is present in the cuDF revision built into the consumed spark-rapids-jni snapshot, so the test that was disabled for NVIDIA#15293 can run again. Closes NVIDIA#15293 Signed-off-by: Igor Peshansky <ipeshansky@nvidia.com>
Greptile SummaryThis PR re-enables a fuzz test for the regex string-split anchor path that was disabled in #15293 while a cuDF bug (lazy-quantifier treated as greedy in
Confidence Score: 5/5Safe to merge — this is a one-line re-enablement of a deterministic fuzz test whose corresponding upstream fix is already present in the consumed cudf-spark-jni snapshot. The change is a single-line swap from Files Needing Attention: No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["string split fuzz - anchor focused test"] --> B["generateDataAndPatterns\n(seed=0L, FuzzRegExp seed=0)"]
B --> C["1000 strings from EnhancedRandom"]
B --> D["5000 regex patterns from FuzzRegExp"]
C & D --> E["doStringSplitTest(patterns, data, limit=-1)"]
E --> F["For each pattern: CPU split via cpuSplit"]
E --> G["For each pattern: transpile via CudfRegexTranspiler"]
G --> H{"transpileToSplittableString?"}
H -- "Some(simplified)" --> I["GPU literal split"]
H -- "None" --> J["GPU regex split via cuDF split_re\n(Glushkov fast path - lazy quantifier fix)"]
F & I --> K["Compare CPU vs GPU results"]
F & J --> K
K --> L{Match?}
L -- Yes --> M[Pass]
L -- No --> N[Fail with details]
Reviews (3): Last reviewed commit: "Merge branch 'main' into reenable-string..." | Re-trigger Greptile |
|
build |
|
build |
Related to #15293.
Description
The cuDF Glushkov fast path no longer treats a lazy quantifier as greedy in split_re (NVIDIA/cudf#23381), and the fix is present in the cuDF revision built into the consumed
cudf-spark-jnisnapshot, so the test that was disabled for #15293 can run again.Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance