Skip to content

Cherry-pick optional nvcomp loading fix from main/ to release/26.08 - #5040

Merged
mythrocks merged 1 commit into
NVIDIA:release/26.08from
mythrocks:handle-optional-nvcomp-26.08
Aug 26, 2026
Merged

mythrocks merged 1 commit into
NVIDIA:release/26.08from
mythrocks:handle-optional-nvcomp-26.08

Conversation

@mythrocks

Copy link
Copy Markdown
Collaborator

This change is in response to NVIDIA/cudf#23766, which backports NVIDIA/cudf#23646 over to the 26.08 release branch of cuDF.

With NVIDIA/cudf/pull/23766, the logic in NativeDepsLoader.java for the handling of the optionally available libnvcomp.so is changed. This causes the spark-rapids-jni custom cuDF patches to stop applying correctly.

This commit cherry-picks bf99e34, with a minor difference in moving thirdparty/cudf to the latest available commit in the cudf 26.08 release branch.

Note that this change does not precipitate a patch release of spark-rapids-jni. It only tidies up after NVIDIA/cudf/pull/23766, to ensure that the next patch release of spark-rapids-jni builds correctly.

This change is in response to NVIDIA/cudf#23766,
which backports NVIDIA/cudf#23646 over to the
26.08 release branch of cuDF.

With 23766, the logic in `NativeDepsLoader.java` for the handling of the
optionally available `libnvcomp.so` is changed.  This causes the
`spark-rapids-jni` custom cuDF patches to stop applying correctly.

This commit cherry-picks NVIDIA@bf99e34,
with a minor difference in moving thirdparty/cudf to the latest available
commit in the cudf `26.08` release branch.

Note that this change does not precipitate a patch release of
`spark-rapids-jni`.  It only tidies up after NVIDIA/cudf/pull/23766,
to ensure that the _next_ patch release of `spark-rapids-jni` builds
correctly.

Signed-off-by: MithunR <mithunr@nvidia.com>
@mythrocks mythrocks self-assigned this Aug 25, 2026
@mythrocks
mythrocks requested a review from a team as a code owner August 25, 2026 21:38
@greptile-apps

greptile-apps Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This backport advances the cuDF 26.08 submodule and removes the obsolete static-nvcomp loader patch after cuDF gained optional nvcomp handling.

  • Makes patch application and cleanup tolerate an empty or absent patch set.
  • Excludes cuDF’s PackagedJarOriginCheck from project Maven and CI test runs.
  • Updates the pinned cuDF submodule revision for the release branch.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete changed-code failure identified.

The patch-management changes support the intentionally empty patch set, the cuDF pin and obsolete nvcomp patch are updated together, and the available evidence does not establish a broken build, runtime loader path, or packaging contract.

Important Files Changed

Filename Overview
thirdparty/cudf Advances the release-branch cuDF revision containing the upstream optional nvcomp loader change.
patches/0001-use-static-nvcomp-from-libcudf.patch Removes the now-obsolete patch that deleted nvcomp from cuDF’s native dependency load order.
build/apply-patches Treats an absent patch directory as a valid no-patches state before canonicalizing its path.
build/unapply-patches Preserves marker-based cleanup while allowing absent cuDF or patch directories to no-op safely.
pom.xml Excludes the inherited packaged-JAR-origin test from normal and sanitizer test executions.
ci/premerge-build.sh Aligns the premerge Maven test selection with the new packaged-JAR-origin exclusion.
ci/nightly-build.sh Aligns nightly test selection with the Maven exclusion.
ci/submodule-sync.sh Aligns submodule synchronization validation with the same test exclusion.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[cuDF 26.08 submodule revision] --> B[Optional nvcomp loader behavior]
  B --> C[No project nvcomp patch required]
  C --> D[Patch scripts accept empty patch set]
  D --> E[Maven native build]
  E --> F[Premerge and nightly validation]
Loading

Reviews (1): Last reviewed commit: "Cherry-pick optional nvcomp loading fix ..." | Re-trigger Greptile

@igorpeshansky

Copy link
Copy Markdown
Collaborator

build

@igorpeshansky igorpeshansky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: modulo the pre-merge checks passing.

@mythrocks
mythrocks merged commit 058dd7a into NVIDIA:release/26.08 Aug 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants