Cherry-pick optional nvcomp loading fix from main/ to release/26.08 - #5040
Merged
mythrocks merged 1 commit intoAug 26, 2026
Merged
Conversation
This change is in response to NVIDIA/cudf#23766, which backports NVIDIA/cudf#23646 over to the 26.08 release branch of cuDF. With 23766, the logic in `NativeDepsLoader.java` for the handling of the optionally available `libnvcomp.so` is changed. This causes the `spark-rapids-jni` custom cuDF patches to stop applying correctly. This commit cherry-picks NVIDIA@bf99e34, with a minor difference in moving thirdparty/cudf to the latest available commit in the cudf `26.08` release branch. Note that this change does not precipitate a patch release of `spark-rapids-jni`. It only tidies up after NVIDIA/cudf/pull/23766, to ensure that the _next_ patch release of `spark-rapids-jni` builds correctly. Signed-off-by: MithunR <mithunr@nvidia.com>
Contributor
Greptile SummaryThis backport advances the cuDF 26.08 submodule and removes the obsolete static-nvcomp loader patch after cuDF gained optional nvcomp handling.
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code failure identified. The patch-management changes support the intentionally empty patch set, the cuDF pin and obsolete nvcomp patch are updated together, and the available evidence does not establish a broken build, runtime loader path, or packaging contract. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[cuDF 26.08 submodule revision] --> B[Optional nvcomp loader behavior]
B --> C[No project nvcomp patch required]
C --> D[Patch scripts accept empty patch set]
D --> E[Maven native build]
E --> F[Premerge and nightly validation]
Reviews (1): Last reviewed commit: "Cherry-pick optional nvcomp loading fix ..." | Re-trigger Greptile |
Collaborator
|
build |
igorpeshansky
approved these changes
Aug 26, 2026
igorpeshansky
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
modulo the pre-merge checks passing.
abellina
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is in response to NVIDIA/cudf#23766, which backports NVIDIA/cudf#23646 over to the 26.08 release branch of cuDF.
With NVIDIA/cudf/pull/23766, the logic in
NativeDepsLoader.javafor the handling of the optionally availablelibnvcomp.sois changed. This causes thespark-rapids-jnicustom cuDF patches to stop applying correctly.This commit cherry-picks bf99e34, with a minor difference in moving thirdparty/cudf to the latest available commit in the cudf
26.08release branch.Note that this change does not precipitate a patch release of
spark-rapids-jni. It only tidies up after NVIDIA/cudf/pull/23766, to ensure that the next patch release ofspark-rapids-jnibuilds correctly.