Skip to content
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,4 +113,3 @@ body:
+-------------------------------+----------------------+----------------------+
validations:
required: false

1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/doc_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,3 @@ body:
label: If this is a correction, please provide a link to the incorrect documentation. If this is a new documentation request, please link to where you have looked.
placeholder: |
https://nvidia.github.io/cuda-python/latest/

1 change: 0 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,3 @@ closes <!-- Link issue here -->
<!-- TODO: - [ ] I am familiar with the [Contributing Guidelines](). -->
- [ ] New or existing tests cover these changes.
- [ ] The documentation is up to date with these changes.

10 changes: 5 additions & 5 deletions .github/actions/doc_preview/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ runs:
using: composite
steps:
# The steps below are executed only when testing in a PR.
# Note: the PR previews will be removed once merged to main (see below)
# Note: the PR previews will be removed once merged to main (see below)
- name: Deploy doc preview
if: ${{ github.ref_name != 'main' }}
uses: JamesIves/github-pages-deploy-action@6c2d9db40f9296374acc17b90404b6e8864128c8 # v4.7.3
Expand All @@ -28,7 +28,7 @@ runs:
folder: ${{ inputs.source-folder }}
target-folder: docs/pr-preview/pr-${{ inputs.pr-number }}/
commit-message: "Deploy doc preview for PR ${{ inputs.pr-number }} (${{ github.sha }})"

- name: Leave a comment after deployment
if: ${{ github.ref_name != 'main' }}
uses: marocchino/sticky-pull-request-comment@67d0dec7b07ed060a405f9b2a64b8ab319fdd7db # v2.9.2
Expand All @@ -43,8 +43,8 @@ runs:
| <br> https://nvidia.github.io/cuda-python/pr-preview/pr-${{ inputs.pr-number }}/cuda-core/ <br>
| <br> https://nvidia.github.io/cuda-python/pr-preview/pr-${{ inputs.pr-number }}/cuda-bindings/ <br><br>
| <h6><br> Preview will be ready when the GitHub Pages deployment is complete. <br><br></h6>
# The steps below are executed only when building on main.

# The steps below are executed only when building on main.
- name: Remove doc preview
if: ${{ github.ref_name == 'main' }}
uses: JamesIves/github-pages-deploy-action@6c2d9db40f9296374acc17b90404b6e8864128c8 # v4.7.3
Expand All @@ -54,7 +54,7 @@ runs:
folder: ${{ inputs.source-folder }}
target-folder: docs/pr-preview/pr-${{ inputs.pr-number }}/
commit-message: "Clean up doc preview for PR ${{ inputs.pr-number }} (${{ github.sha }})"

- name: Leave a comment after removal
if: ${{ github.ref_name == 'main' }}
uses: marocchino/sticky-pull-request-comment@67d0dec7b07ed060a405f9b2a64b8ab319fdd7db # v2.9.2
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/install_unix_deps/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ inputs:
dependencies:
required: true
type: string
dependent_exes:
dependent_exes:
required: true
type: string

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-upload.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
run: |
# Use the shared script to download wheels
./ci/tools/download-wheels "${{ inputs.run-id }}" "${{ inputs.component }}" "${{ github.repository }}" "release/wheels"

# Upload wheels to the release
if [[ -d "release/wheels" && $(ls -A release/wheels 2>/dev/null | wc -l) -gt 0 ]]; then
echo "Uploading wheels to release ${{ inputs.git-tag }}"
Expand Down
21 changes: 21 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ ci:
skip: [bandit]
submodules: false

gen_exclude: &gen_exclude '^cuda_bindings/cuda/bindings/.*\.in?$'
Comment thread
leofang marked this conversation as resolved.
Outdated

# Please update the rev: SHAs below with this command:
# pre-commit autoupdate --freeze
repos:
Expand Down Expand Up @@ -39,6 +41,25 @@ repos:
pass_filenames: false
always_run: true

# Standard hooks
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: "v5.0.0"
hooks:
- id: check-added-large-files
- id: check-case-conflict
- id: check-docstring-first
- id: check-merge-conflict
- id: check-symlinks
- id: check-toml
- id: check-yaml
- id: debug-statements
- id: end-of-file-fixer
exclude: *gen_exclude
- id: mixed-line-ending
- id: requirements-txt-fixer
- id: trailing-whitespace
exclude: *gen_exclude

# Checking for common mistakes
- repo: https://github.com/pre-commit/pygrep-hooks
rev: "v1.10.0"
Expand Down
1 change: 0 additions & 1 deletion SECURITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,3 @@ information.

For all security-related concerns, please visit NVIDIA's Product Security portal at
<https://www.nvidia.com/en-us/security>.

8 changes: 4 additions & 4 deletions ci/tools/download-wheels
Original file line number Diff line number Diff line change
Expand Up @@ -49,18 +49,18 @@ do
if [[ ! -d "$p" ]]; then
continue
fi

# exclude cython test artifacts
if [[ "${p}" == *-tests ]]; then
echo "Skipping test artifact: $p"
continue
fi

# If we're not downloading "all", only process matching component
if [[ "$COMPONENT" != "all" && "$p" != ${COMPONENT}* ]]; then
continue
fi

echo "Processing artifact: $p"
# Move wheel files to output directory
if [[ -d "$p" ]]; then
Expand All @@ -72,4 +72,4 @@ done
rm -rf cuda-*

echo "Downloaded wheels to: $OUTPUT_DIR"
ls -la "$OUTPUT_DIR"
ls -la "$OUTPUT_DIR"
Loading