This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Cleanup CTK version checks #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhemstad
reviewed
Feb 20, 2023
| #if (__CUDACC_VER_MAJOR__ >= 11 || CUDA_VERSION >= 11000) && !_NVHPC_CUDA && \ | ||
| !defined(CUB_DISABLE_BF16_SUPPORT) | ||
| #include <cuda_bf16.h> | ||
| #if !_NVHPC_CUDA && !defined(CUB_DISABLE_BF16_SUPPORT) |
There was a problem hiding this comment.
Does bf16 not work on nvc++?
If so, would it make sense to just add the _NVHPC_CUDA check into CUB_DISABLE_BF16_SUPPORT?
jrhemstad
reviewed
Feb 20, 2023
jrhemstad
approved these changes
Feb 20, 2023
gevtushenko
force-pushed
the
fix-main/github/int128
branch
from
30205e5
to
5dce195
Compare
gevtushenko
added a commit
to gevtushenko/thrust
that referenced
this pull request
Mar 5, 2023
miscco
approved these changes
Mar 5, 2023
gevtushenko
added
testing: gpuCI passed
This was referenced Mar 6, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the int128 usage for CTK < 11.5 and also cleans up a few outdated checks (CTK < 11.0).