Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

First version of developer overview #537

Merged

Conversation

gevtushenko
Copy link
Collaborator

This PR briefly explains the current CUB design. The document is intended to help contributors. Coming PTX dispatch changes will lead to changes in this document. Having a diff of design overview will ease the transition period (still having a few PRs in flight that apply existing dispatch logic).

@gevtushenko gevtushenko added only: docs Documentation changes only. Doesn't need code CI. area: docs Related to documentation. labels Jul 21, 2022
Copy link
Collaborator

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work!

I did some cursory glances over the document

docs/developer_overview.md Show resolved Hide resolved
docs/developer_overview.md Outdated Show resolved Hide resolved
docs/developer_overview.md Outdated Show resolved Hide resolved
docs/developer_overview.md Outdated Show resolved Hide resolved
docs/developer_overview.md Show resolved Hide resolved
docs/developer_overview.md Show resolved Hide resolved
Copy link
Collaborator

@elstehle elstehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really great and important initiative! This is great work and something that we can continue to build on and adding to in the future. Thanks for putting this together, @senior-zero!

I only have a few minor suggestions.

In general, I was wondering if we want to agree and communicate some fundamental contractual details. E.g., that Device-scope algorithms do not synchronise the host with the device (cudaSyncrhonize or cudaStreamSynchronize).

docs/developer_overview.md Outdated Show resolved Hide resolved
docs/developer_overview.md Show resolved Hide resolved
docs/developer_overview.md Outdated Show resolved Hide resolved
docs/developer_overview.md Outdated Show resolved Hide resolved
docs/developer_overview.md Outdated Show resolved Hide resolved
docs/developer_overview.md Show resolved Hide resolved
@alliepiper alliepiper added this to the 2.1.0 milestone Jul 25, 2022
Copy link
Collaborator

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing this document, @senior-zero! I have a small handful of comments. I learned a lot from reading this!

docs/developer_overview.md Outdated Show resolved Hide resolved
docs/developer_overview.md Outdated Show resolved Hide resolved
docs/developer_overview.md Outdated Show resolved Hide resolved
docs/developer_overview.md Show resolved Hide resolved
@gevtushenko gevtushenko force-pushed the feature-main/github/developer_overview branch 5 times, most recently from 0d8336c to c4be103 Compare August 19, 2022 08:40
Co-authored-by: Jake Hemstad <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Elias Stehle <[email protected]>
@gevtushenko gevtushenko force-pushed the feature-main/github/developer_overview branch from c4be103 to d99e2fb Compare August 19, 2022 10:12
@jrhemstad jrhemstad merged commit 68a6288 into NVIDIA:main Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: docs Related to documentation. only: docs Documentation changes only. Doesn't need code CI.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants