Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

update Iterate (BlockDiscontinuity) to use pragma unroll #450

Merged
merged 2 commits into from
Apr 25, 2022
Merged

update Iterate (BlockDiscontinuity) to use pragma unroll #450

merged 2 commits into from
Apr 25, 2022

Conversation

kshitij12345
Copy link
Contributor

@kshitij12345 kshitij12345 commented Mar 24, 2022 •
edited
Loading

Fixes: #337

@kshitij12345 kshitij12345 changed the title update iterate to use pragma unroll update Iterate (BlockDiscontinuity) to use pragma unroll Mar 24, 2022
@kshitij12345 kshitij12345 marked this pull request as ready for review March 24, 2022 19:08
@kshitij12345
Copy link
Contributor Author

cc: @allisonvacanti

@alliepiper alliepiper added type: enhancement New feature or request. P1: should have Necessary, but not critical. labels Apr 4, 2022
@alliepiper alliepiper added this to the 1.17.0 milestone Apr 4, 2022
@alliepiper
Copy link
Collaborator

@kshitij12345 it looks like the same pattern is used for BlockAdjacentDifference. Could you push a similar PR that makes the same change for that algorithm?

alliepiper
alliepiper suggested changes Apr 4, 2022
View reviewed changes
cub/block/block_discontinuity.cuh Outdated Show resolved Hide resolved
alliepiper added a commit to alliepiper/thrust that referenced this pull request Apr 6, 2022
@alliepiper
Testing NVIDIA/cub#450.
db85a38
@alliepiper
Copy link
Collaborator

gpuCI: NVIDIA/thrust#1655

@alliepiper alliepiper added the testing: gpuCI in progress Started gpuCI testing. label Apr 6, 2022
@kshitij12345 kshitij12345 mentioned this pull request Apr 7, 2022
Merged
@alliepiper alliepiper removed the testing: gpuCI in progress Started gpuCI testing. label Apr 22, 2022
alliepiper added a commit to alliepiper/thrust that referenced this pull request Apr 22, 2022
@alliepiper
Testing NVIDIA/cub#450.
bc460bf
@alliepiper
Copy link
Collaborator

gpuCI: NVIDIA/thrust#1655

@alliepiper alliepiper added the testing: gpuCI in progress Started gpuCI testing. label Apr 22, 2022
@alliepiper alliepiper merged commit d2c014c into NVIDIA:main Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alliepiper alliepiper alliepiper approved these changes

@gevtushenko gevtushenko gevtushenko approved these changes

Assignees
No one assigned
Labels
P1: should have Necessary, but not critical. testing: gpuCI in progress Started gpuCI testing. type: enhancement New feature or request.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Remove manual loop unrolling
3 participants
@kshitij12345 @alliepiper @gevtushenko