This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Add BFloat16 support for radix sort #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review, tests pass. |
|
This looks good to me. Thanks for taking the time to work on this! Can squash the branch down to a single commit, and also change the comment about PyTorch in the test wrapper implementation? I know it's meant casually, but some internal legal folks may have an overreaction to that phrasing ;) |
|
@allisonvacanti I have squashed this PR, and changed the comment to: |
|
Thanks -- I'll start tests soon. |
|
Rebased and noted bfloat16 support in the docs. My doc change will conflict with #307, but I'll resolve that when merging this. Starting tests now. |
alliepiper
added a commit
to alliepiper/thrust
that referenced
this pull request
May 20, 2021
|
gpuCI: NVIDIA/thrust#1439 DVS CL: 29986609 |
alliepiper
added
testing: internal ci in progress
alliepiper
added a commit
to alliepiper/thrust
that referenced
this pull request
May 21, 2021
alliepiper
approved these changes
Jun 8, 2021
alliepiper
added
testing: internal ci passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.