Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Put in somewhat hacky fix for out of bounds accesses #160

Closed
wants to merge 1 commit into from

Conversation

jwyles
Copy link

@jwyles jwyles commented Apr 25, 2019

This is a somewhat hacky fix for the out of bounds memory accesses noted in issue #139, hopefully this will help in finding the root cause of the issue.

@alliepiper
Copy link
Collaborator

Looks like this was closed accidentally during the repo move. Reopening.

@alliepiper alliepiper reopened this Oct 21, 2020
@alliepiper alliepiper marked this pull request as draft October 21, 2020 20:58
@alliepiper
Copy link
Collaborator

Converting to draft to prevent merging -- without looking too closely, it looks like this is meant to provide context about #139, not necessarily resolve it.

@alliepiper alliepiper changed the base branch from 1.8.0 to main October 21, 2020 21:06
@brycelelbach brycelelbach added this to the 1.12.0 milestone Dec 18, 2020
Copy link
Collaborator

@brycelelbach brycelelbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't look that hacky to me.

@alliepiper alliepiper modified the milestones: 1.12.0, 1.13.0 Feb 16, 2021
@brycelelbach brycelelbach added P1: should have Necessary, but not critical. type: bug: functional Does not work as intended. labels Mar 29, 2021
@alliepiper alliepiper modified the milestones: 1.13.0, 1.14.0 Jun 9, 2021
@alliepiper alliepiper linked an issue Jul 30, 2021 that may be closed by this pull request
@alliepiper alliepiper self-assigned this Jul 30, 2021
alliepiper added a commit to alliepiper/cub that referenced this pull request Jul 30, 2021
alliepiper added a commit to alliepiper/cub that referenced this pull request Jul 30, 2021
alliepiper added a commit to alliepiper/cub that referenced this pull request Jul 30, 2021
alliepiper added a commit to alliepiper/cub that referenced this pull request Jul 30, 2021
@alliepiper
Copy link
Collaborator

Closing -- #352 incorporates the changes from this PR, fixes some other issues, and adds testing for DeviceSpmv. Thanks for the contribution!

@alliepiper alliepiper closed this Jul 30, 2021
alliepiper added a commit to alliepiper/cub that referenced this pull request Aug 2, 2021
alliepiper added a commit to alliepiper/cub that referenced this pull request Aug 2, 2021
alliepiper added a commit to alliepiper/cub that referenced this pull request Aug 4, 2021
alliepiper added a commit to alliepiper/cub that referenced this pull request Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1: should have Necessary, but not critical. type: bug: functional Does not work as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpMV out-of-bounds accesses
3 participants