This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 447
Put in somewhat hacky fix for out of bounds accesses #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like this was closed accidentally during the repo move. Reopening. |
Converting to draft to prevent merging -- without looking too closely, it looks like this is meant to provide context about #139, not necessarily resolve it. |
brycelelbach
approved these changes
Jan 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These don't look that hacky to me.
brycelelbach
added
P1: should have
Necessary, but not critical.
type: bug: functional
Does not work as intended.
labels
Mar 29, 2021
alliepiper
added a commit
to alliepiper/cub
that referenced
this pull request
Jul 30, 2021
This extends the solution in PR NVIDIA#160.
alliepiper
added a commit
to alliepiper/cub
that referenced
this pull request
Jul 30, 2021
This extends the solution in PR NVIDIA#160.
alliepiper
added a commit
to alliepiper/cub
that referenced
this pull request
Jul 30, 2021
This fix was suggested in PR NVIDIA#160.
alliepiper
added a commit
to alliepiper/cub
that referenced
this pull request
Jul 30, 2021
This fix was suggested in PR NVIDIA#160.
Closing -- #352 incorporates the changes from this PR, fixes some other issues, and adds testing for |
alliepiper
added a commit
to alliepiper/cub
that referenced
this pull request
Aug 2, 2021
This extends the solution in PR NVIDIA#160.
alliepiper
added a commit
to alliepiper/cub
that referenced
this pull request
Aug 2, 2021
This fix was suggested in PR NVIDIA#160.
alliepiper
added a commit
to alliepiper/cub
that referenced
this pull request
Aug 4, 2021
This extends the solution in PR NVIDIA#160.
alliepiper
added a commit
to alliepiper/cub
that referenced
this pull request
Aug 4, 2021
This fix was suggested in PR NVIDIA#160.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat hacky fix for the out of bounds memory accesses noted in issue #139, hopefully this will help in finding the root cause of the issue.