Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insert_or_apply #579

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Conversation

srinivasyadav18
Copy link
Contributor

This PR cleans up some of the issues occured during merge of #551.

  1. propagate the key_eq and probing_scheme from global ref to constructor of shared_memory_ref in insert_or_apply_shmem kernel.
  2. Disable init overload of insert_or_apply using sfinae, because cuda::stream_ref is default constructed, this can invoke the init overload even though the user calls no-init overload.

Copy link

copy-pr-bot bot commented Aug 15, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@PointKernel PointKernel added the type: bug Something isn't working label Aug 15, 2024
@PointKernel
Copy link
Member

/ok to test

@PointKernel PointKernel merged commit 6eaed1b into NVIDIA:dev Aug 16, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants