xxhash cleanups #313
Merged
xxhash cleanups #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleeepyjack
commented
Jun 1, 2023
| @@ -86,20 +86,20 @@ struct XXHash_32 { | |||
| constexpr result_type __host__ __device__ operator()(Key const& key) const noexcept | |||
| { | |||
| // TODO do we need to add checks/hints for alignment? | |||
There was a problem hiding this comment.
Can someone comment on this? I'm not sure if the excessive reinterpret_casting leads to pitfalls.
There was a problem hiding this comment.
Based on the offline discussion, downcasting to the char pointer shouldn't cause any problems and blocks (or the uint32_t pointer) won't be used if the key size is smaller than 4 bytes so the current implementation should be safe.
There was a problem hiding this comment.
8c4f167 sprinkles in some [[maybe_unused]] attributes for good measure.
PointKernel
reviewed
Jun 1, 2023
| @@ -86,20 +86,20 @@ struct XXHash_32 { | |||
| constexpr result_type __host__ __device__ operator()(Key const& key) const noexcept | |||
| { | |||
| // TODO do we need to add checks/hints for alignment? | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up on #310 and addresses review comments from @bdice.