Skip to content

Commit

Permalink
Merge branch 'dev' into expose
Browse files Browse the repository at this point in the history
  • Loading branch information
PointKernel authored Aug 7, 2024
2 parents 38ca389 + d625fca commit 27a1420
Show file tree
Hide file tree
Showing 9 changed files with 714 additions and 154 deletions.
3 changes: 2 additions & 1 deletion benchmarks/static_map/insert_or_apply_bench.cu
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

#include <cuco/static_map.cuh>
#include <cuco/utility/key_generator.cuh>
#include <cuco/utility/reduction_functors.cuh>

#include <nvbench/nvbench.cuh>

Expand Down Expand Up @@ -60,7 +61,7 @@ std::enable_if_t<(sizeof(Key) == sizeof(Value)), void> static_map_insert_or_appl
state.exec(nvbench::exec_tag::timer, [&](nvbench::launch& launch, auto& timer) {
timer.start();
map.insert_or_apply_async(
pairs.begin(), pairs.end(), cuco::op::reduce::sum, {launch.get_stream()});
pairs.begin(), pairs.end(), cuco::reduce::plus{}, {launch.get_stream()});
timer.stop();
map.clear_async({launch.get_stream()});
});
Expand Down
115 changes: 115 additions & 0 deletions include/cuco/detail/static_map/helpers.cuh
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
/*
* Copyright (c) 2024, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#pragma once

#include <cuco/detail/static_map/kernels.cuh>
#include <cuco/detail/utility/cuda.cuh>

namespace cuco::static_map_ns::detail {

/**
* @brief Dispatches to shared memory map kernel if `num_elements_per_thread > 2`, else
* fallbacks to global memory map kernel.
*
* @tparam HasInit Boolean to dispatch based on init parameter
* @tparam CGSize Number of threads in each CG
* @tparam Allocator Allocator type used to created shared_memory map
* @tparam InputIt Device accessible input iterator whose `value_type` is
* convertible to the `value_type` of the data structure
* @tparam Init Type of init value convertible to payload type
* @tparam Op Callable type used to peform `apply` operation.
* @tparam Ref Type of non-owning device ref allowing access to storage
*
* @param first Beginning of the sequence of input elements
* @param last End of the sequence of input elements
* @param init The init value of the `op`
* @param op Callable object to perform apply operation.
* @param ref Non-owning container device ref used to access the slot storage
* @param stream CUDA stream used for insert_or_apply operation
*/
template <bool HasInit,
int32_t CGSize,
typename Allocator,
typename InputIt,
typename Init,
typename Op,
typename Ref>
void dispatch_insert_or_apply(
InputIt first, InputIt last, Init init, Op op, Ref ref, cuda::stream_ref stream)
{
auto const num = cuco::detail::distance(first, last);
if (num == 0) { return; }

int32_t const default_grid_size = cuco::detail::grid_size(num, CGSize);

if constexpr (CGSize == 1) {
using shmem_size_type = int32_t;

int32_t constexpr shmem_block_size = 1024;
shmem_size_type constexpr cardinality_threshold = shmem_block_size;
shmem_size_type constexpr shared_map_num_elements = cardinality_threshold + shmem_block_size;
float constexpr load_factor = 0.7;
shmem_size_type constexpr shared_map_size =
static_cast<shmem_size_type>((1.0 / load_factor) * shared_map_num_elements);

using extent_type = cuco::extent<shmem_size_type, shared_map_size>;
using shared_map_type = cuco::static_map<typename Ref::key_type,
typename Ref::mapped_type,
extent_type,
cuda::thread_scope_block,
typename Ref::key_equal,
typename Ref::probing_scheme_type,
Allocator,
cuco::storage<1>>;

using shared_map_ref_type = typename shared_map_type::ref_type<>;
auto constexpr window_extent = cuco::make_window_extent<shared_map_ref_type>(extent_type{});

auto insert_or_apply_shmem_fn_ptr = insert_or_apply_shmem<HasInit,
CGSize,
shmem_block_size,
shared_map_ref_type,
InputIt,
Init,
Op,
Ref>;

int32_t const max_op_grid_size =
cuco::detail::max_occupancy_grid_size(shmem_block_size, insert_or_apply_shmem_fn_ptr);

int32_t const shmem_default_grid_size =
cuco::detail::grid_size(num, CGSize, cuco::detail::default_stride(), shmem_block_size);

auto const shmem_grid_size = std::min(shmem_default_grid_size, max_op_grid_size);
auto const num_elements_per_thread = num / (shmem_grid_size * shmem_block_size);

// use shared_memory only if each thread has atleast 3 elements to process
if (num_elements_per_thread > 2) {
insert_or_apply_shmem<HasInit, CGSize, shmem_block_size, shared_map_ref_type>
<<<shmem_grid_size, shmem_block_size, 0, stream.get()>>>(
first, num, init, op, ref, window_extent);
} else {
insert_or_apply<HasInit, CGSize, cuco::detail::default_block_size()>
<<<default_grid_size, cuco::detail::default_block_size(), 0, stream.get()>>>(
first, num, init, op, ref);
}
} else {
insert_or_apply<HasInit, CGSize, cuco::detail::default_block_size()>
<<<default_grid_size, cuco::detail::default_block_size(), 0, stream.get()>>>(
first, num, init, op, ref);
}
}
} // namespace cuco::static_map_ns::detail
93 changes: 79 additions & 14 deletions include/cuco/detail/static_map/kernels.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -77,47 +77,101 @@ CUCO_KERNEL __launch_bounds__(BlockSize) void insert_or_assign(InputIt first,
*
* @note Callable object to perform binary operation should be able to invoke as
* Op(cuda::atomic_ref<T,Scope>, T>)
* @note If `HasInit` is `true` and if `init == empty_sentinel_value`, we directly
* `apply` the `op` instead of atomic store and then waiting for the payload to get materalized.
* This has potential speedups when insert strategy is not `packed_cas`.
*
* @tparam HasInit Boolean to dispatch based on init parameter
* @tparam CGSize Number of threads in each CG
* @tparam BlockSize Number of threads in each block
* @tparam InputIt Device accessible input iterator whose `value_type` is
* convertible to the `value_type` of the data structure
* @tparam Init Type of init value convertible to payload type
* @tparam Op Callable type used to peform `apply` operation.
* @tparam Ref Type of non-owning device ref allowing access to storage
*
* @param first Beginning of the sequence of input elements
* @param n Number of input elements
* @param init The init value of the op
* @param op Callable object to perform apply operation.
* @param ref Non-owning container device ref used to access the slot storage
*/
template <int32_t CGSize, int32_t BlockSize, typename InputIt, typename Op, typename Ref>
__global__ void insert_or_apply(InputIt first, cuco::detail::index_type n, Op op, Ref ref)
template <bool HasInit,
int32_t CGSize,
int32_t BlockSize,
typename InputIt,
typename Init,
typename Op,
typename Ref>
__global__ void insert_or_apply(
InputIt first, cuco::detail::index_type n, [[maybe_unused]] Init init, Op op, Ref ref)
{
auto const loop_stride = cuco::detail::grid_stride() / CGSize;
auto idx = cuco::detail::global_thread_id() / CGSize;

while (idx < n) {
typename std::iterator_traits<InputIt>::value_type const& insert_pair = *(first + idx);
using value_type = typename std::iterator_traits<InputIt>::value_type;
value_type const& insert_pair = *(first + idx);
if constexpr (CGSize == 1) {
ref.insert_or_apply(insert_pair, op);
if constexpr (HasInit) {
ref.insert_or_apply(insert_pair, init, op);
} else {
ref.insert_or_apply(insert_pair, op);
}
} else {
auto const tile =
cooperative_groups::tiled_partition<CGSize>(cooperative_groups::this_thread_block());
ref.insert_or_apply(tile, insert_pair, op);
if constexpr (HasInit) {
ref.insert_or_apply(tile, insert_pair, init, op);
} else {
ref.insert_or_apply(tile, insert_pair, op);
}
}
idx += loop_stride;
}
}

template <int32_t CGSize,
/**
* @brief For any key-value pair `{k, v}` in the range `[first, first + n)`, if a key equivalent to
* `k` already exists in the container, then binary operation is applied using `op` callable object
* on the existing value at slot and the element to insert. If the key does not exist, inserts the
* pair as if by insert.
*
* @note Callable object to perform binary operation should be able to invoke as
* Op(cuda::atomic_ref<T,Scope>, T>)
* @note If `HasInit` is `true` and if `init == empty_sentinel_value`, we directly
* `apply` the `op` instead of atomic store and then waiting for the payload to get materalized.
* This has potential speedups when insert strategy is not `packed_cas`.
*
* @tparam HasInit Boolean to dispatch based on init parameter
* @tparam CGSize Number of threads in each CG
* @tparam BlockSize Number of threads in each block
* @tparam SharedMapRefType The Shared Memory Map Ref Type
* @tparam InputIt Device accessible input iterator whose `value_type` is
* convertible to the `value_type` of the data structure
* @tparam Init Type of init value convertible to payload type
* @tparam Op Callable type used to peform `apply` operation.
* @tparam Ref Type of non-owning device ref allowing access to storage
*
* @param first Beginning of the sequence of input elements
* @param n Number of input elements
* @param init The init value of the op
* @param op Callable object to perform apply operation.
* @param ref Non-owning container device ref used to access the slot storage
* @param window_extent Window Extent used for shared memory map slot storage
*/
template <bool HasInit,
int32_t CGSize,
int32_t BlockSize,
class SharedMapRefType,
class InputIt,
class Init,
class Op,
class Ref>
CUCO_KERNEL __launch_bounds__(BlockSize) void insert_or_apply_shmem(
InputIt first,
cuco::detail::index_type n,
[[maybe_unused]] Init init,
Op op,
Ref ref,
typename SharedMapRefType::extent_type window_extent)
Expand Down Expand Up @@ -157,18 +211,22 @@ CUCO_KERNEL __launch_bounds__(BlockSize) void insert_or_apply_shmem(
block.sync();

while ((idx - thread_idx / CGSize) < n) {
int32_t inserted = 0;
int32_t local_cardinality = 0;
int32_t inserted = 0;
int32_t warp_cardinality = 0;
// insert-or-apply into the shared map first
if (idx < n) {
value_type const& insert_pair = *(first + idx);
inserted = shared_map_ref.insert_or_apply(insert_pair, op);
if constexpr (HasInit) {
inserted = shared_map_ref.insert_or_apply(insert_pair, init, op);
} else {
inserted = shared_map_ref.insert_or_apply(insert_pair, op);
}
}
if (idx - warp_thread_idx < n) { // all threads in warp particpate
local_cardinality = cg::reduce(warp, inserted, cg::plus<int32_t>());
warp_cardinality = cg::reduce(warp, inserted, cg::plus<int32_t>());
}
if (warp_thread_idx == 0) {
block_cardinality.fetch_add(local_cardinality, cuda::memory_order_relaxed);
block_cardinality.fetch_add(warp_cardinality, cuda::memory_order_relaxed);
}
block.sync();
if (block_cardinality > BlockSize) { break; }
Expand All @@ -180,7 +238,11 @@ CUCO_KERNEL __launch_bounds__(BlockSize) void insert_or_apply_shmem(
while (window_idx < num_windows) {
auto const slot = storage[window_idx][0];
if (not cuco::detail::bitwise_compare(slot.first, ref.empty_key_sentinel())) {
ref.insert_or_apply(slot, op);
if constexpr (HasInit) {
ref.insert_or_apply(slot, init, op);
} else {
ref.insert_or_apply(slot, op);
}
}
window_idx += BlockSize;
}
Expand All @@ -191,10 +253,13 @@ CUCO_KERNEL __launch_bounds__(BlockSize) void insert_or_apply_shmem(
idx += loop_stride;
while (idx < n) {
value_type const& insert_pair = *(first + idx);
ref.insert_or_apply(insert_pair, op);
if constexpr (HasInit) {
ref.insert_or_apply(insert_pair, init, op);
} else {
ref.insert_or_apply(insert_pair, op);
}
idx += loop_stride;
}
}
}

} // namespace cuco::static_map_ns::detail
Loading

0 comments on commit 27a1420

Please sign in to comment.