Skip to content

part deux: make the abi of __basic_any compatible between c++17 and c++20 - #7405

Merged
ericniebler merged 1 commit into
NVIDIA:mainfrom
ericniebler:cross-dialect-basic-any-abi-stability
Jan 29, 2026
Merged

part deux: make the abi of __basic_any compatible between c++17 and c++20#7405
ericniebler merged 1 commit into
NVIDIA:mainfrom
ericniebler:cross-dialect-basic-any-abi-stability

Conversation

@ericniebler

@ericniebler ericniebler commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

Description

part 2 of #7401. @bdice confirms that this, in addition to #7401, fixes the ABI issue in RMM.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-bot Bot commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Progress in CCCL Jan 29, 2026
@ericniebler ericniebler linked an issue Jan 29, 2026 that may be closed by this pull request
1 task
@ericniebler

Copy link
Copy Markdown
Contributor Author

/ok to test 88a1c9a

@ericniebler
ericniebler marked this pull request as ready for review January 29, 2026 02:19
@ericniebler
ericniebler requested a review from a team as a code owner January 29, 2026 02:19
@ericniebler
ericniebler requested a review from fbusato January 29, 2026 02:19
@cccl-authenticator-app cccl-authenticator-app Bot moved this from In Progress to In Review in CCCL Jan 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🥳 CI Workflow Results

🟩 Finished in 1h 21m: Pass: 100%/95 | Total: 1d 00h | Max: 1h 17m | Hits: 96%/246998

See results here.

@bdice bdice left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I confirmed this is necessary and sufficient with some testing in rapidsai/rmm#2233.

@ericniebler
ericniebler merged commit 0d9331d into NVIDIA:main Jan 29, 2026
116 of 117 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in CCCL Jan 29, 2026
@ericniebler
ericniebler deleted the cross-dialect-basic-any-abi-stability branch January 29, 2026 17:02
github-actions Bot pushed a commit that referenced this pull request Jan 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

bdice pushed a commit that referenced this pull request Feb 3, 2026
…atible between c++17 and c++20 (#7421)

* make the abi of `__basic_any` compatible between c++17 and c++20 (#7405)

(cherry picked from commit 0d9331d)

* make the abi of `__basic_any` compatible between c++17 and c++20 (#7401)

---------

Co-authored-by: Eric Niebler <eniebler@nvidia.com>
fbusato pushed a commit to fbusato/cccl that referenced this pull request Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG]: -std=c++XX flag forms part of ABI for __basic_any

3 participants