Repository navigation
Align local vector storage arrays in vec transform - #7162
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
elstehle
approved these changes
Jan 11, 2026
davebayer
approved these changes
Jan 11, 2026
bernhardmgruber
enabled auto-merge (squash)
January 11, 2026 19:00
Contributor
🥳 CI Workflow Results🟩 Finished in 21h 24m: Pass: 100%/128 | Total: 6d 20h | Max: 5h 00m | Hits: 57%/176785See results here. |
Contributor
|
Successfully created backport PR for |
bernhardmgruber
added a commit
that referenced
this pull request
Jan 12, 2026
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 26, 2026
…rrays in vec transform (NVIDIA/cccl#7162) (NVIDIA/cccl#7163) Upstream: NVIDIA/cccl@5281dca HIP counterpart (system/hip): none; the Alignment parameter only serves CUB's vectorized transform (cub part not applicable), and system/hip uses rocPRIM transform. Ported the uninitialized_array Alignment template parameter in system/cuda/detail/core/util.h. test/ counterpart: none. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 29, 2026
…rrays in vec transform (NVIDIA/cccl#7162) (NVIDIA/cccl#7163) Upstream: NVIDIA/cccl@5281dca HIP counterpart (system/hip): none; the Alignment parameter only serves CUB's vectorized transform (cub part not applicable), and system/hip uses rocPRIM transform. Ported the uninitialized_array Alignment template parameter in system/cuda/detail/core/util.h. test/ counterpart: none. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 29, 2026
…rrays in vec transform (NVIDIA/cccl#7162) (NVIDIA/cccl#7163) Upstream: NVIDIA/cccl@5281dca HIP counterpart (system/hip): none; the Alignment parameter only serves CUB's vectorized transform (cub part not applicable), and system/hip uses rocPRIM transform. Ported the uninitialized_array Alignment template parameter in system/cuda/detail/core/util.h. test/ counterpart: none. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 30, 2026
…rrays in vec transform (NVIDIA/cccl#7162) (NVIDIA/cccl#7163) Upstream: NVIDIA/cccl@5281dca HIP counterpart (system/hip): none; the Alignment parameter only serves CUB's vectorized transform (cub part not applicable), and system/hip uses rocPRIM transform. Ported the uninitialized_array Alignment template parameter in system/cuda/detail/core/util.h. test/ counterpart: none. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Beanavil
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 30, 2026
…rrays in vec transform (NVIDIA/cccl#7162) (NVIDIA/cccl#7163) Upstream: NVIDIA/cccl@5281dca HIP counterpart (system/hip): none; the Alignment parameter only serves CUB's vectorized transform (cub part not applicable), and system/hip uses rocPRIM transform. Ported the uninitialized_array Alignment template parameter in system/cuda/detail/core/util.h. test/ counterpart: none. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
amd-jmahovsky
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Nov 4, 2026
…rrays in vec transform (NVIDIA/cccl#7162) Upstream: NVIDIA/cccl@b7ebe1e - Already ported: identical to branch/3.2.x backport 5281dcaefdc, ported locally as 9e88cdc - HIP counterpart: none needed (handled when the backport was ported) - test/ counterpart: none needed (upstream change has no tests) - Not compiled, tests not run (autonomous no-build mode) Co-Authored-By: Claude <noreply@anthropic.com>
amd-jmahovsky
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Nov 4, 2026
…rrays in vec transform (NVIDIA/cccl#7162) Upstream: NVIDIA/cccl@b7ebe1e - Already ported: identical to branch/3.2.x backport 5281dcaefdc, ported locally as 9e88cdc - HIP counterpart: none needed (handled when the backport was ported) - test/ counterpart: none needed (upstream change has no tests) - Not compiled, tests not run (autonomous no-build mode) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously only aligned to
alignof(T)and notalignof(T) * vec_size. This wasn't noticed since the compiler just keeps the data in registers anyway. However, in a debug build, the arrays are spilled to local memory so the alignment matters.Small SASS changes for
cub.test.device.transform.lid_0on sm86 and sm120 but only a few immediates:I am not worried, given we also need the fix for correctness.
Fixes: #7160