[dunga1k58bh]

Description

closes #6589

• Port all 15 test structs from complex.cu to catch2_test_complex.cu
• Fix mistake in ComplexMemberOperators: change b_thrust vs b_thrust
  comparison to b_thrust vs b_std (line 385 in original file)

Checklist

• New or existing tests cover these changes.
• The documentation is up to date with these changes.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[bernhardmgruber]

/ok to test 90b6333

[bernhardmgruber]

@dunga1k58bh thank you for taking a stab at this! This is super helpful!

[dunga1k58bh]

@bernhardmgruber A pull request failed, but I think it's due to an environment configuration error. What should I do now?

Command ''sccache' '--start-server'' failed with status 2. Retrying in 30 seconds...
Attempt 5 of 5: Running command ''sccache' '--start-server''
sccache: Starting sccache v0.12.0-rapids.10...
sccache: error: Server startup failed: cache storage failed to read: PermissionDenied (permanent) at read => S3Error { code: "SignatureDoesNotMatch", message: "The request signature we calculated does not match the signature you provided. Check your key and signing method.", resource: "", request_id: "PYVQVY1EB7K9VKAF" }

[bernhardmgruber]

/ok to test 3747cf2

[bernhardmgruber]

@bernhardmgruber A pull request failed, but I think it's due to an environment configuration error. What should I do now?

We sometimes have CI hickups that require us to manually rerun the CI. Sorry about that! Just wait or ping a maintainer if this happens!

[dunga1k58bh]

@bernhardmgruber Failed due to out of memory

2025-11-16T00:38:31.6520669Z 1 catastrophic error detected in the compilation of "C:/cccl/thrust/testing/catch2_test_transform.cu".
2025-11-16T00:38:31.6521194Z Compilation terminated.
2025-11-16T00:38:31.6526890Z Catastrophic error: out of memory

[bernhardmgruber]

I see an OOM error at compile-time:

  C:\cccl\libcudacxx\include\cuda/std/__fwd/subrange.h(47): catastrophic error: out of memory
              enable_if_t<(_Kind == subrange_kind::sized || !sized_sentinel_for<_Sent, _Iter>), int> = 0>
                           ^
            detected during:
              instantiation of

so I guess the compiler hit a limit on the runner.

[bernhardmgruber]

Important: the previous code default constructed b here:

thrust::complex<T> b;

please retain this.

Was there a particular reason, this needed to be changed?

[dunga1k58bh]

When I use the default constructor, I get a warning due to -Werror=maybe-uninitialized, because some values may not be initialized. Anyway, I changed it to use default initialization instead.

/home/coder/cccl/thrust/testing/catch2_test_complex.cu: In function ‘void CATCH2_INTERNAL_TEMPLATE_TEST_36() [with TestType = float]’:
/home/coder/cccl/thrust/testing/catch2_test_complex.cu:655:22: note: ‘b.thrust::complex<float>::data.thrust::complex<float>::storage::x’ was declared here
  655 |   thrust::complex<T> b;
      |                      ^
In constructor ‘Catch::Approx::Approx(const T&) [with T = float; <template-parameter-1-2> = void]’,
    inlined from ‘cuda::std::__4::enable_if_t<((bool)(is_complex<T1> && is_complex<T2>))> {anonymous}::require_almost_equal(const T1&, const T2&) [with T1 = thrust::complex<float>; T2 = thrust::complex<float>]’ at /home/coder/cccl/thrust/testing/catch2_test_complex.cu:62:3,
    inlined from ‘void CATCH2_INTERNAL_TEMPLATE_TEST_36() [with TestType = float]’ at /home/coder/cccl/thrust/testing/catch2_test_complex.cu:657:23:
/home/coder/cccl/build/cuda13.0-gcc14/thrust-cpp20/_deps/catch2-src/src/catch2/catch_approx.hpp:42:77: error: ‘b.thrust::complex<float>::data.thrust::complex<float>::storage::y’ may be used uninitialized [-Werror=maybe-uninitialized]
   42 |         explicit Approx( T const& value ): Approx(static_cast<double>(value))
      |                                                                             ^
/home/coder/cccl/thrust/testing/catch2_test_complex.cu: In function ‘void CATCH2_INTERNAL_TEMPLATE_TEST_36() [with TestType = float]’:
/home/coder/cccl/thrust/testing/catch2_test_complex.cu:655:22: note: ‘b.thrust::complex<float>::data.thrust::complex<float>::storage::y’ was declared here
  655 |   thrust::complex<T> b;
      |                      ^

[bernhardmgruber]

Important: let's use normal function name spelling, so we don't clash if we introduce a macro REQUIRE_ALMOST_EQUAL (which I may plan to do).

Suggested change

	template <typename T1, typename T2>
	::cuda::std::enable_if_t<is_complex<T1>::value && is_complex<T2>::value> REQUIRE_ALMOST_EQUAL(const T1& a, const T2& b)
	{
	CHECK(a.real() == Catch::Approx(b.real()).margin(DEFAULT_ABSOLUTE_TOL).epsilon(DEFAULT_RELATIVE_TOL));
	CHECK(a.imag() == Catch::Approx(b.imag()).margin(DEFAULT_ABSOLUTE_TOL).epsilon(DEFAULT_RELATIVE_TOL));
	}
	template <typename T1, typename T2>
	::cuda::std::enable_if_t<!is_complex<T1>::value && !is_complex<T2>::value> REQUIRE_ALMOST_EQUAL(const T1& a, const T2& b)
	{
	CHECK(a == Catch::Approx(b).margin(DEFAULT_ABSOLUTE_TOL).epsilon(DEFAULT_RELATIVE_TOL));
	}
	template <typename T1, typename T2>
	::cuda::std::enable_if_t<is_complex<T1>::value && is_complex<T2>::value> require_almost_equal(const T1& a, const T2& b)
	{
	CHECK(a.real() == Catch::Approx(b.real()).margin(DEFAULT_ABSOLUTE_TOL).epsilon(DEFAULT_RELATIVE_TOL));
	CHECK(a.imag() == Catch::Approx(b.imag()).margin(DEFAULT_ABSOLUTE_TOL).epsilon(DEFAULT_RELATIVE_TOL));
	}
	template <typename T1, typename T2>
	::cuda::std::enable_if_t<!is_complex<T1>::value && !is_complex<T2>::value> require_almost_equal(const T1& a, const T2& b)
	{
	CHECK(a == Catch::Approx(b).margin(DEFAULT_ABSOLUTE_TOL).epsilon(DEFAULT_RELATIVE_TOL));
	}

[dunga1k58bh]

I have updated the code based on your suggestion.

[bernhardmgruber]

/ok to test 1bfcc1e

[github-actions]

🥳 CI Workflow Results

🟩 Finished in 2h 16m: Pass: 100%/70 | Total: 22h 43m | Max: 2h 13m | Hits: 99%/115481

See results here.

[bernhardmgruber]

Great work, thx!