Repository navigation
Replace enum by static constexpr in CUB/Thrust - #6480
Merged
Merged
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
davebayer
approved these changes
Nov 4, 2025
miscco
reviewed
Nov 4, 2025
Contributor
Author
|
I would like to avoid any other refactoring than replacing enumerators by |
bernhardmgruber
force-pushed
the
no_enum2
branch
from
November 4, 2025 16:45
6f9568e to
ec5e787
Compare
bernhardmgruber
marked this pull request as ready for review
November 4, 2025 16:46
fbusato
requested changes
Nov 4, 2025
fbusato
approved these changes
Nov 4, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
force-pushed
the
no_enum2
branch
from
November 5, 2025 15:21
3036593 to
b1e178b
Compare
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
force-pushed
the
no_enum2
branch
from
November 6, 2025 08:43
b1e178b to
835a95c
Compare
miscco
approved these changes
Nov 6, 2025
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
force-pushed
the
no_enum2
branch
2 times, most recently
from
November 6, 2025 18:56
b1c460f to
b648eb2
Compare
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
force-pushed
the
no_enum2
branch
from
November 7, 2025 02:39
b648eb2 to
1393476
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
force-pushed
the
no_enum2
branch
from
November 8, 2025 20:40
1393476 to
c1f6f64
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
/ok to test 4633c22 |
Contributor
🥳 CI Workflow Results🟩 Finished in 5h 06m: Pass: 100%/124 | Total: 7d 07h | Max: 5h 05m | Hits: 52%/167602See results here. |
miscco
approved these changes
Nov 11, 2025
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 26, 2026
…expr in CUB/Thrust (NVIDIA/cccl#6480) Upstream: NVIDIA/cccl@06f2025 HIP counterpart (system/hip): none; system/hip has no anonymous-enum constants of this form. Ported enum -> static constexpr in system/cuda (agent_launcher.h, core/util.h, reduce.h, reduce_by_key.h, set_operations.h); util.h conflict resolved to static constexpr bool value while keeping local ::cuda::std::true_type/false_type. test/ counterpart: none. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 29, 2026
…expr in CUB/Thrust (NVIDIA/cccl#6480) Upstream: NVIDIA/cccl@06f2025 HIP counterpart (system/hip): none; system/hip has no anonymous-enum constants of this form. Ported enum -> static constexpr in system/cuda (agent_launcher.h, core/util.h, reduce.h, reduce_by_key.h, set_operations.h); util.h conflict resolved to static constexpr bool value while keeping local ::cuda::std::true_type/false_type. test/ counterpart: none. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 29, 2026
…expr in CUB/Thrust (NVIDIA/cccl#6480) Upstream: NVIDIA/cccl@06f2025 HIP counterpart (system/hip): none; system/hip has no anonymous-enum constants of this form. Ported enum -> static constexpr in system/cuda (agent_launcher.h, core/util.h, reduce.h, reduce_by_key.h, set_operations.h); util.h conflict resolved to static constexpr bool value while keeping local ::cuda::std::true_type/false_type. test/ counterpart: none. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 30, 2026
…expr in CUB/Thrust (NVIDIA/cccl#6480) Upstream: NVIDIA/cccl@06f2025 HIP counterpart (system/hip): none; system/hip has no anonymous-enum constants of this form. Ported enum -> static constexpr in system/cuda (agent_launcher.h, core/util.h, reduce.h, reduce_by_key.h, set_operations.h); util.h conflict resolved to static constexpr bool value while keeping local ::cuda::std::true_type/false_type. test/ counterpart: none. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Beanavil
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 30, 2026
…expr in CUB/Thrust (NVIDIA/cccl#6480) Upstream: NVIDIA/cccl@06f2025 HIP counterpart (system/hip): none; system/hip has no anonymous-enum constants of this form. Ported enum -> static constexpr in system/cuda (agent_launcher.h, core/util.h, reduce.h, reduce_by_key.h, set_operations.h); util.h conflict resolved to static constexpr bool value while keeping local ::cuda::std::true_type/false_type. test/ counterpart: none. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.