Repository navigation
Move CPP, OMP and TBB exec policies to detail - #6361
Merged
Merged
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 03381f3 |
miscco
approved these changes
Oct 28, 2025
bernhardmgruber
force-pushed
the
fix_exec
branch
from
October 28, 2025 15:45
a9e528e to
5a445fe
Compare
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 57m: Pass: 100%/69 | Total: 3d 01h | Max: 2h 56m | Hits: 57%/115211See results here. |
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 26, 2026
…olicies to detail (NVIDIA/cccl#6361) Upstream: NVIDIA/cccl@e73cc82 HIP counterpart (system/hip): no change; hip tag/execution_policy already live in thrust::hip_rocprim alongside the HIP algorithms, so ADL already finds them (the cuda change is only a comment). cpp/omp/tbb tag + execution_policy moved into system::<sys>::detail with using-declarations in system::<sys>, as upstream. omp/detail/scan.inl: P0571 accumulator (no-init tag, wrapped_function, init applied in block-sum scan), keeping the libhipcxx-free includes (_THRUST_STD_INCLUDE(type_traits) added, libcxx_wrapper invoke.h include dropped as accumulator_t is no longer used). test/: test_scan.cpp only_set_when_expected_it gains postfix operator++(int). testing/: scan.cu same (THRUST_HOST_DEVICE spelling). Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
amd-jmahovsky
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 28, 2026
…ceil_div in omp/tbb scan Related upstream commit: 1238f287f4f add parallel scan support for TBB and OMP (NVIDIA/cccl#6178) Related upstream commit: e73cc82956a Move CPP, OMP and TBB exec policies to detail (NVIDIA/cccl#6361) Related upstream commit: c22298179e0 Refactor Thrust OMP system headers (NVIDIA/cccl#6372) Related local port commits: 6cb9dc4, 43961ea, e6c2a3e libhipcxx is now mandatory, so: - system/omp/detail/scan.h: replace the <algorithm>/<iterator>/<numeric>/<type_traits> umbrella includes and thrust/{advance,distance}.h with the upstream granular headers (__cmath/ceil_div.h, __functional/invoke.h, __iterator/{advance,distance}.h, __numeric/{exclusive_scan,inclusive_scan,reduce}.h, __type_traits/{conditional,is_same}.h; plus __algorithm/{max,min}.h for the max/min calls), and compute block_size with _THRUST_LIBCXX::ceil_div(n, num_threads) as upstream. - system/tbb/detail/scan.h: thrust/{advance,distance}.h -> _THRUST_STD __iterator/{advance,distance}.h. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 29, 2026
…olicies to detail (NVIDIA/cccl#6361) Upstream: NVIDIA/cccl@e73cc82 HIP counterpart (system/hip): no change; hip tag/execution_policy already live in thrust::hip_rocprim alongside the HIP algorithms, so ADL already finds them (the cuda change is only a comment). cpp/omp/tbb tag + execution_policy moved into system::<sys>::detail with using-declarations in system::<sys>, as upstream. omp/detail/scan.inl: P0571 accumulator (no-init tag, wrapped_function, init applied in block-sum scan), keeping the libhipcxx-free includes (_THRUST_STD_INCLUDE(type_traits) added, libcxx_wrapper invoke.h include dropped as accumulator_t is no longer used). test/: test_scan.cpp only_set_when_expected_it gains postfix operator++(int). testing/: scan.cu same (THRUST_HOST_DEVICE spelling). Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 29, 2026
…olicies to detail (NVIDIA/cccl#6361) Upstream: NVIDIA/cccl@e73cc82 HIP counterpart (system/hip): no change; hip tag/execution_policy already live in thrust::hip_rocprim alongside the HIP algorithms, so ADL already finds them (the cuda change is only a comment). cpp/omp/tbb tag + execution_policy moved into system::<sys>::detail with using-declarations in system::<sys>, as upstream. omp/detail/scan.inl: P0571 accumulator (no-init tag, wrapped_function, init applied in block-sum scan), keeping the libhipcxx-free includes (_THRUST_STD_INCLUDE(type_traits) added, libcxx_wrapper invoke.h include dropped as accumulator_t is no longer used). test/: test_scan.cpp only_set_when_expected_it gains postfix operator++(int). testing/: scan.cu same (THRUST_HOST_DEVICE spelling). Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 29, 2026
…ceil_div in omp/tbb scan Related upstream commit: 1238f287f4f add parallel scan support for TBB and OMP (NVIDIA/cccl#6178) Related upstream commit: e73cc82956a Move CPP, OMP and TBB exec policies to detail (NVIDIA/cccl#6361) Related upstream commit: c22298179e0 Refactor Thrust OMP system headers (NVIDIA/cccl#6372) Related local port commits: 6cb9dc4, 43961ea, e6c2a3e libhipcxx is now mandatory, so: - system/omp/detail/scan.h: replace the <algorithm>/<iterator>/<numeric>/<type_traits> umbrella includes and thrust/{advance,distance}.h with the upstream granular headers (__cmath/ceil_div.h, __functional/invoke.h, __iterator/{advance,distance}.h, __numeric/{exclusive_scan,inclusive_scan,reduce}.h, __type_traits/{conditional,is_same}.h; plus __algorithm/{max,min}.h for the max/min calls), and compute block_size with _THRUST_LIBCXX::ceil_div(n, num_threads) as upstream. - system/tbb/detail/scan.h: thrust/{advance,distance}.h -> _THRUST_STD __iterator/{advance,distance}.h. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 30, 2026
…olicies to detail (NVIDIA/cccl#6361) Upstream: NVIDIA/cccl@e73cc82 HIP counterpart (system/hip): no change; hip tag/execution_policy already live in thrust::hip_rocprim alongside the HIP algorithms, so ADL already finds them (the cuda change is only a comment). cpp/omp/tbb tag + execution_policy moved into system::<sys>::detail with using-declarations in system::<sys>, as upstream. omp/detail/scan.inl: P0571 accumulator (no-init tag, wrapped_function, init applied in block-sum scan), keeping the libhipcxx-free includes (_THRUST_STD_INCLUDE(type_traits) added, libcxx_wrapper invoke.h include dropped as accumulator_t is no longer used). test/: test_scan.cpp only_set_when_expected_it gains postfix operator++(int). testing/: scan.cu same (THRUST_HOST_DEVICE spelling). Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Beanavil
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 30, 2026
…olicies to detail (NVIDIA/cccl#6361) Upstream: NVIDIA/cccl@e73cc82 HIP counterpart (system/hip): no change; hip tag/execution_policy already live in thrust::hip_rocprim alongside the HIP algorithms, so ADL already finds them (the cuda change is only a comment). cpp/omp/tbb tag + execution_policy moved into system::<sys>::detail with using-declarations in system::<sys>, as upstream. omp/detail/scan.inl: P0571 accumulator (no-init tag, wrapped_function, init applied in block-sum scan), keeping the libhipcxx-free includes (_THRUST_STD_INCLUDE(type_traits) added, libcxx_wrapper invoke.h include dropped as accumulator_t is no longer used). test/: test_scan.cpp only_set_when_expected_it gains postfix operator++(int). testing/: scan.cu same (THRUST_HOST_DEVICE spelling). Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
amd-jmahovsky
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 30, 2026
…ceil_div in omp/tbb scan Related upstream commit: 1238f287f4f add parallel scan support for TBB and OMP (NVIDIA/cccl#6178) Related upstream commit: e73cc82956a Move CPP, OMP and TBB exec policies to detail (NVIDIA/cccl#6361) Related upstream commit: c22298179e0 Refactor Thrust OMP system headers (NVIDIA/cccl#6372) Related local port commits: 6cb9dc4, 43961ea, e6c2a3e libhipcxx is now mandatory, so: - system/omp/detail/scan.h: replace the <algorithm>/<iterator>/<numeric>/<type_traits> umbrella includes and thrust/{advance,distance}.h with the upstream granular headers (__cmath/ceil_div.h, __functional/invoke.h, __iterator/{advance,distance}.h, __numeric/{exclusive_scan,inclusive_scan,reduce}.h, __type_traits/{conditional,is_same}.h; plus __algorithm/{max,min}.h for the max/min calls), and compute block_size with _THRUST_LIBCXX::ceil_div(n, num_threads) as upstream. - system/tbb/detail/scan.h: thrust/{advance,distance}.h -> _THRUST_STD __iterator/{advance,distance}.h. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #6359
Fixes: #6317