Repository navigation
Refactor generic thrust scan dispatch - #6360
Merged
Merged
Conversation
miscco
approved these changes
Oct 28, 2025
bernhardmgruber
enabled auto-merge (squash)
October 28, 2025 12:54
elstehle
approved these changes
Oct 28, 2025
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 48m: Pass: 100%/69 | Total: 2d 19h | Max: 2h 39m | Hits: 57%/115211See results here. |
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 26, 2026
… dispatch (NVIDIA/cccl#6360) Upstream: NVIDIA/cccl@85bf1b0 HIP: generic dispatch header; scan.inl folded into scan.h and the backend-required binary_op overloads are now "= delete" (HIP backend provides them), applies to HIP automatically. Uses <thrust/functional.h> instead of _THRUST_LIBCXX_INCLUDE(functional) so builds without libhipcxx still get _THRUST_STD::plus; THRUST_HOST_DEVICE spelling kept. git rm generic/scan.inl. test/: no counterpart. testing/: no counterpart. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
amd-jmahovsky
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 28, 2026
…onal> in generic scan Related upstream commit: 85bf1b00c4d Refactor generic thrust scan dispatch (NVIDIA/cccl#6360) Related local port commit: fc66966 system/detail/generic/scan.h uses _THRUST_STD::plus<>; include _THRUST_LIBCXX_INCLUDE(functional) (upstream <cuda/functional>) instead of <thrust/functional.h>, now that libhipcxx is mandatory. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 29, 2026
… dispatch (NVIDIA/cccl#6360) Upstream: NVIDIA/cccl@85bf1b0 HIP: generic dispatch header; scan.inl folded into scan.h and the backend-required binary_op overloads are now "= delete" (HIP backend provides them), applies to HIP automatically. Uses <thrust/functional.h> instead of _THRUST_LIBCXX_INCLUDE(functional) so builds without libhipcxx still get _THRUST_STD::plus; THRUST_HOST_DEVICE spelling kept. git rm generic/scan.inl. test/: no counterpart. testing/: no counterpart. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 29, 2026
… dispatch (NVIDIA/cccl#6360) Upstream: NVIDIA/cccl@85bf1b0 HIP: generic dispatch header; scan.inl folded into scan.h and the backend-required binary_op overloads are now "= delete" (HIP backend provides them), applies to HIP automatically. Uses <thrust/functional.h> instead of _THRUST_LIBCXX_INCLUDE(functional) so builds without libhipcxx still get _THRUST_STD::plus; THRUST_HOST_DEVICE spelling kept. git rm generic/scan.inl. test/: no counterpart. testing/: no counterpart. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 29, 2026
…onal> in generic scan Related upstream commit: 85bf1b00c4d Refactor generic thrust scan dispatch (NVIDIA/cccl#6360) Related local port commit: fc66966 system/detail/generic/scan.h uses _THRUST_STD::plus<>; include _THRUST_LIBCXX_INCLUDE(functional) (upstream <cuda/functional>) instead of <thrust/functional.h>, now that libhipcxx is mandatory. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 30, 2026
… dispatch (NVIDIA/cccl#6360) Upstream: NVIDIA/cccl@85bf1b0 HIP: generic dispatch header; scan.inl folded into scan.h and the backend-required binary_op overloads are now "= delete" (HIP backend provides them), applies to HIP automatically. Uses <thrust/functional.h> instead of _THRUST_LIBCXX_INCLUDE(functional) so builds without libhipcxx still get _THRUST_STD::plus; THRUST_HOST_DEVICE spelling kept. git rm generic/scan.inl. test/: no counterpart. testing/: no counterpart. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Beanavil
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 30, 2026
… dispatch (NVIDIA/cccl#6360) Upstream: NVIDIA/cccl@85bf1b0 HIP: generic dispatch header; scan.inl folded into scan.h and the backend-required binary_op overloads are now "= delete" (HIP backend provides them), applies to HIP automatically. Uses <thrust/functional.h> instead of _THRUST_LIBCXX_INCLUDE(functional) so builds without libhipcxx still get _THRUST_STD::plus; THRUST_HOST_DEVICE spelling kept. git rm generic/scan.inl. test/: no counterpart. testing/: no counterpart. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
amd-jmahovsky
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 30, 2026
…onal> in generic scan Related upstream commit: 85bf1b00c4d Refactor generic thrust scan dispatch (NVIDIA/cccl#6360) Related local port commit: fc66966 system/detail/generic/scan.h uses _THRUST_STD::plus<>; include _THRUST_LIBCXX_INCLUDE(functional) (upstream <cuda/functional>) instead of <thrust/functional.h>, now that libhipcxx is mandatory. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.