Repository navigation
Improve invoke machinery - #6227
Merged
Merged
Conversation
bernhardmgruber
approved these changes
Oct 14, 2025
davebayer
approved these changes
Oct 14, 2025
This comment has been minimized.
This comment has been minimized.
miscco
force-pushed
the
improve_invoke
branch
from
October 15, 2025 06:06
31265db to
5d01872
Compare
davebayer
enabled auto-merge (squash)
October 15, 2025 09:22
Contributor
🥳 CI Workflow Results🟩 Finished in 5h 09m: Pass: 100%/171 | Total: 10d 19h | Max: 5h 08m | Hits: 24%/358170See results here. |
amd-jmahovsky
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 28, 2026
…hs in detail/type_traits.h Related upstream commit: c859e948453 Improve `invoke` machinery (NVIDIA/cccl#6227) Related local port commit: 33e87b6 (pre-rebase SHA; folded into the rebased history) The port switched only the libhipcxx branch to _THRUST_STD::invoke_result and left the "TODO(libhipcxx): remove this path" rocprim/std fallbacks. libhipcxx is now mandatory, so thrust::detail::invoke_result is just _THRUST_STD::invoke_result as upstream, and the dead rocprim/std fallbacks for the ::internal aliases (is_arithmetic, is_integral, make_unsigned, decay_t, remove_cvref, ...), ::internal::detail::common_type and the <rocprim/type_traits_functions.hpp> include are removed. The ::internal aliases themselves stay for now (they still have users). Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 29, 2026
…hs in detail/type_traits.h Related upstream commit: c859e948453 Improve `invoke` machinery (NVIDIA/cccl#6227) Related local port commit: 33e87b6 (pre-rebase SHA; folded into the rebased history) The port switched only the libhipcxx branch to _THRUST_STD::invoke_result and left the "TODO(libhipcxx): remove this path" rocprim/std fallbacks. libhipcxx is now mandatory, so thrust::detail::invoke_result is just _THRUST_STD::invoke_result as upstream, and the dead rocprim/std fallbacks for the ::internal aliases (is_arithmetic, is_integral, make_unsigned, decay_t, remove_cvref, ...), ::internal::detail::common_type and the <rocprim/type_traits_functions.hpp> include are removed. The ::internal aliases themselves stay for now (they still have users). Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
amd-jmahovsky
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 30, 2026
…hs in detail/type_traits.h Related upstream commit: c859e948453 Improve `invoke` machinery (NVIDIA/cccl#6227) Related local port commit: 33e87b6 (pre-rebase SHA; folded into the rebased history) The port switched only the libhipcxx branch to _THRUST_STD::invoke_result and left the "TODO(libhipcxx): remove this path" rocprim/std fallbacks. libhipcxx is now mandatory, so thrust::detail::invoke_result is just _THRUST_STD::invoke_result as upstream, and the dead rocprim/std fallbacks for the ::internal aliases (is_arithmetic, is_integral, make_unsigned, decay_t, remove_cvref, ...), ::internal::detail::common_type and the <rocprim/type_traits_functions.hpp> include are removed. The ::internal aliases themselves stay for now (they still have users). Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of the fundamental facilities in the whole library, which was still using a lot of structs.
This modernizes it to rely on inline variables and concepts when possible