Replace __popc with cude::std::popcounter by viralbhadeshiya · Pull Request #6213 · NVIDIA/cccl

viralbhadeshiya · 2025-10-14T04:15:55Z

Description

closes #6107

Replace all __popc occurrence with cuda::std::pop_count

Checklist

New or existing tests cover these changes.
The documentation is up to date with these changes.

copy-pr-bot · 2025-10-14T04:15:59Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

davebayer · 2025-10-14T06:25:47Z

/ok to test afd9ae6

davebayer · 2025-10-14T06:26:41Z

Thanks for working on this :)

davebayer

There is one more __popc(...) left in thrust/thrust/system/cuda/detail/set_operations.h

viralbhadeshiya · 2025-10-14T15:43:19Z

There is one more __popc(...) left in thrust/thrust/system/cuda/detail/set_operations.h

This is done.

davebayer · 2025-10-14T15:46:19Z

/ok to test 00154d6

miscco · 2025-10-15T07:59:36Z

@elstehle can I bully you into checking SASS?

elstehle

Confirmed that there are no sass changes.

Fyi, these are the steps I usually follow to check whether there are any sass changes:

Identify the Device* algorithm(s) that may be affected by a change. This isn't always straight-forward. Sometimes, the change may only be affected on certain GPU architectures (this would require looking into the tuning policy of affected algorithms)
Compile the benchmarks for the specific Device* algorithm(s) identified in (1) and dump the sass code. E.g., ninja cub.bench.radix_sort.keys.base && cuobjdump -sass ./bin/cub.bench.radix_sort.keys.base |c++filt > ./radix_sort.keys_after.sass.
Checkout the main branch to compare against baseline sass code being generated: git checkout $(git merge-base HEAD upstream/main)
Dump the sass code emitted on main branch. E.g., ninja cub.bench.radix_sort.keys.base && cuobjdump -sass ./bin/cub.bench.radix_sort.keys.base |c++filt > ./radix_sort.keys_before.sass.
Check whether there are sass changes: git diff --text --no-index --word-diff radix_sort.keys_before.sass radix_sort.keys_after.sass

viralbhadeshiya · 2025-10-20T17:00:33Z

can we run test on this PR? other then that I think everything is done.

davebayer · 2025-10-20T17:18:23Z

/ok to test ff78f01

github-actions · 2025-10-21T12:02:55Z

🥳 CI Workflow Results

🟩 Finished in 18h 40m: Pass: 100%/176 | Total: 9d 04h | Max: 4h 48m | Hits: 62%/358506

See results here.

miscco · 2025-10-22T06:24:58Z

Thanks a lot @viralbhadeshiya for working on this 🎉

--------- Co-authored-by: David Bayer <48736217+davebayer@users.noreply.github.com>

…d::popcounter (NVIDIA/cccl#6213) Upstream: NVIDIA/cccl@638c03d HIP: no change; hip/detail/set_operations.h keeps the HIP __popc intrinsic (valid on all HIP targets; switching to _THRUST_STD::popcount would require libhipcxx and gives no correctness benefit). system/cuda: __popc -> ::cuda::std::popcount. test/: no counterpart. testing/: no counterpart. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>

…unt in hip set_operations Related upstream commit: 638c03d54f7 Replace __popc with cude::std::popcounter (NVIDIA/cccl#6213) Related local port commit: baac406 The port changed only system/cuda. libhipcxx is now mandatory, so system/hip/detail/set_operations.h follows upstream: thread_output_count uses _THRUST_STD::popcount(static_cast<unsigned>(active_mask)) instead of the __popc intrinsic, includes _THRUST_STD_INCLUDE(__bit/popcount.h), and the max/min includes are no longer guarded (the !_THRUST_HAS_DEVICE_SYSTEM_STD algorithm_wrapper.h fallback is removed). Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>

…d::popcounter (NVIDIA/cccl#6213) Upstream: NVIDIA/cccl@638c03d HIP: no change; hip/detail/set_operations.h keeps the HIP __popc intrinsic (valid on all HIP targets; switching to _THRUST_STD::popcount would require libhipcxx and gives no correctness benefit). system/cuda: __popc -> ::cuda::std::popcount. test/: no counterpart. testing/: no counterpart. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>

…unt in hip set_operations Related upstream commit: 638c03d54f7 Replace __popc with cude::std::popcounter (NVIDIA/cccl#6213) Related local port commit: baac406 The port changed only system/cuda. libhipcxx is now mandatory, so system/hip/detail/set_operations.h follows upstream: thread_output_count uses _THRUST_STD::popcount(static_cast<unsigned>(active_mask)) instead of the __popc intrinsic, includes _THRUST_STD_INCLUDE(__bit/popcount.h), and the max/min includes are no longer guarded (the !_THRUST_HAS_DEVICE_SYSTEM_STD algorithm_wrapper.h fallback is removed). Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>

…d::popcounter (NVIDIA/cccl#6213) Upstream: NVIDIA/cccl@638c03d HIP: no change; hip/detail/set_operations.h keeps the HIP __popc intrinsic (valid on all HIP targets; switching to _THRUST_STD::popcount would require libhipcxx and gives no correctness benefit). system/cuda: __popc -> ::cuda::std::popcount. test/: no counterpart. testing/: no counterpart. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>

…unt in hip set_operations Related upstream commit: 638c03d54f7 Replace __popc with cude::std::popcounter (NVIDIA/cccl#6213) Related local port commit: baac406 The port changed only system/cuda. libhipcxx is now mandatory, so system/hip/detail/set_operations.h follows upstream: thread_output_count uses _THRUST_STD::popcount(static_cast<unsigned>(active_mask)) instead of the __popc intrinsic, includes _THRUST_STD_INCLUDE(__bit/popcount.h), and the max/min includes are no longer guarded (the !_THRUST_HAS_DEVICE_SYSTEM_STD algorithm_wrapper.h fallback is removed). Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>

replace __popc with cude::std::popcounter

afd9ae6

viralbhadeshiya requested review from a team as code owners October 14, 2025 04:15

github-project-automation Bot added this to CCCL Oct 14, 2025

viralbhadeshiya requested a review from alliepiper October 14, 2025 04:15

github-project-automation Bot moved this to Todo in CCCL Oct 14, 2025

viralbhadeshiya requested review from NaderAlAwar and griwes October 14, 2025 04:15

cccl-authenticator-app Bot moved this from Todo to In Review in CCCL Oct 14, 2025

davebayer approved these changes Oct 14, 2025

View reviewed changes

miscco requested changes Oct 14, 2025

View reviewed changes

Comment thread libcudacxx/examples/nv_target.cu Resolved

github-project-automation Bot moved this from In Review to In Progress in CCCL Oct 14, 2025

This comment has been minimized.

Sign in to view

davebayer reviewed Oct 14, 2025

View reviewed changes

Comment thread libcudacxx/examples/nv_target.cu Resolved

Comment thread libcudacxx/examples/nv_target.cu Resolved

davebayer added 2 commits October 14, 2025 15:30

Update libcudacxx/examples/nv_target.cu

9f4a6b3

Update libcudacxx/examples/nv_target.cu

34fa334

davebayer requested changes Oct 14, 2025

View reviewed changes

viralbhadeshiya added 2 commits October 14, 2025 08:42

replace missed __popc from previous commit

90db707

Merge branch 'FEA/6107' of github.com:viralbhadeshiya/cccl into FEA/6107

00154d6

viralbhadeshiya requested a review from a team as a code owner October 14, 2025 15:42

viralbhadeshiya requested a review from gevtushenko October 14, 2025 15:42

davebayer approved these changes Oct 14, 2025

View reviewed changes

davebayer reviewed Oct 14, 2025

View reviewed changes

Comment thread thrust/thrust/system/cuda/detail/set_operations.h Resolved

Apply suggestion from @davebayer

7f523b4

This comment has been minimized.

Sign in to view

davebayer requested a review from miscco October 14, 2025 18:07

fbusato reviewed Oct 14, 2025

View reviewed changes

Comment thread thrust/thrust/system/cuda/detail/set_operations.h Resolved

viralbhadeshiya added 2 commits October 14, 2025 11:31

apply suggestion from @fbusato

e9d3c36

Merge branch 'FEA/6107' of github.com:viralbhadeshiya/cccl into FEA/6107

5671b6f

fbusato approved these changes Oct 14, 2025

View reviewed changes

elstehle approved these changes Oct 15, 2025

View reviewed changes

Merge branch 'main' into FEA/6107

ff78f01

This comment has been minimized.

Sign in to view

bernhardmgruber approved these changes Oct 21, 2025

View reviewed changes

miscco approved these changes Oct 22, 2025

View reviewed changes

github-project-automation Bot moved this from In Progress to In Review in CCCL Oct 22, 2025

miscco merged commit 638c03d into NVIDIA:main Oct 22, 2025
557 of 564 checks passed

github-project-automation Bot moved this from In Review to Done in CCCL Oct 22, 2025

pciolkosz pushed a commit to pciolkosz/cccl that referenced this pull request Oct 23, 2025

Replace __popc with cude::std::popcounter (NVIDIA#6213)

b2e0d9f

--------- Co-authored-by: David Bayer <48736217+davebayer@users.noreply.github.com>

pciolkosz pushed a commit to pciolkosz/cccl that referenced this pull request Oct 24, 2025

Replace __popc with cude::std::popcounter (NVIDIA#6213)

b9fecf2

--------- Co-authored-by: David Bayer <48736217+davebayer@users.noreply.github.com>

Conversation

viralbhadeshiya commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

copy-pr-bot Bot commented Oct 14, 2025

Uh oh!

davebayer commented Oct 14, 2025

Uh oh!

davebayer commented Oct 14, 2025

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

davebayer left a comment

Choose a reason for hiding this comment

Uh oh!

viralbhadeshiya commented Oct 14, 2025

Uh oh!

davebayer commented Oct 14, 2025

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

miscco commented Oct 15, 2025

Uh oh!

elstehle left a comment

Choose a reason for hiding this comment

Uh oh!

viralbhadeshiya commented Oct 20, 2025

Uh oh!

davebayer commented Oct 20, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

github-actions Bot commented Oct 21, 2025

🥳 CI Workflow Results

🟩 Finished in 18h 40m: Pass: 100%/176 | Total: 9d 04h | Max: 4h 48m | Hits: 62%/358506

Uh oh!

Uh oh!

miscco commented Oct 22, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

viralbhadeshiya commented Oct 14, 2025 •

edited

Loading