-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds virtual shared memory helper and tests #619
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alliepiper
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nits, but otherwise lgtm
2 tasks
gevtushenko
approved these changes
Nov 9, 2023
miscco
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a virtual shared memory helper utility. This utility helps to work around the limitation of a CUB algorithm requiring more shared memory than is available per thread block (by default, 48K of static shared memory). This scenario usually only becomes relevant for large user types, e.g., once they exceed hundred(s) of bytes and more.
The utility has two mechanisms to work around this limitation:
virtual shared memory
, which is memory backed by global memory.Closes #553 and #1082
The plan is to put the new vsmem utility to use in a follow-up PR by integrating it into
DeviceMergeSort
for further evaluation. Once the API has proven to be robust, I'll add further documentation in theDeveloper Overview
.Checklist