Repository navigation
Ensure non-trivial thrust::copy from D2D uses UBLKCP - #5954
Merged
Merged
Conversation
fbusato
approved these changes
Sep 19, 2025
This comment has been minimized.
This comment has been minimized.
miscco
approved these changes
Sep 22, 2025
bernhardmgruber
force-pushed
the
copy_BULK
branch
from
September 22, 2025 20:42
3785680 to
2ccf298
Compare
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
force-pushed
the
copy_BULK
branch
from
September 23, 2025 18:39
2ccf298 to
f6dad65
Compare
bernhardmgruber
force-pushed
the
copy_BULK
branch
from
September 23, 2025 18:39
f6dad65 to
b45cc37
Compare
bernhardmgruber
enabled auto-merge (squash)
September 23, 2025 21:53
Contributor
🥳 CI Workflow Results🟩 Finished in 3h 31m: Pass: 100%/185 | Total: 6d 10h | Max: 3h 29m | Hits: 75%/186504See results here. |
pciolkosz
pushed a commit
to pciolkosz/cccl
that referenced
this pull request
Sep 24, 2025
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 26, 2026
…opy from D2D uses UBLKCP (NVIDIA/cccl#5954) Upstream: NVIDIA/cccl@36ec00b - cuda `copy.h`: non-trivial device-to-device copy wraps `::cuda::std::identity` in `::cuda::proclaim_copyable_arguments` so DeviceTransform can use UBLKCP (merged cleanly). cub `kernels/transform.cuh` belongs to hipCUB. - HIP counterpart: no change: performance-only. - test/ counterpart: none; testing/ counterpart: none. - Not compiled, tests not run (per human). Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 29, 2026
…opy from D2D uses UBLKCP (NVIDIA/cccl#5954) Upstream: NVIDIA/cccl@36ec00b - cuda `copy.h`: non-trivial device-to-device copy wraps `::cuda::std::identity` in `::cuda::proclaim_copyable_arguments` so DeviceTransform can use UBLKCP (merged cleanly). cub `kernels/transform.cuh` belongs to hipCUB. - HIP counterpart: no change: performance-only. - test/ counterpart: none; testing/ counterpart: none. - Not compiled, tests not run (per human). Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 29, 2026
…opy from D2D uses UBLKCP (NVIDIA/cccl#5954) Upstream: NVIDIA/cccl@36ec00b - cuda `copy.h`: non-trivial device-to-device copy wraps `::cuda::std::identity` in `::cuda::proclaim_copyable_arguments` so DeviceTransform can use UBLKCP (merged cleanly). cub `kernels/transform.cuh` belongs to hipCUB. - HIP counterpart: no change: performance-only. - test/ counterpart: none; testing/ counterpart: none. - Not compiled, tests not run (per human). Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 30, 2026
…opy from D2D uses UBLKCP (NVIDIA/cccl#5954) Upstream: NVIDIA/cccl@36ec00b - cuda `copy.h`: non-trivial device-to-device copy wraps `::cuda::std::identity` in `::cuda::proclaim_copyable_arguments` so DeviceTransform can use UBLKCP (merged cleanly). cub `kernels/transform.cuh` belongs to hipCUB. - HIP counterpart: no change: performance-only. - test/ counterpart: none; testing/ counterpart: none. - Not compiled, tests not run (per human). Co-Authored-By: Claude <noreply@anthropic.com>
Beanavil
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 30, 2026
…opy from D2D uses UBLKCP (NVIDIA/cccl#5954) Upstream: NVIDIA/cccl@36ec00b - cuda `copy.h`: non-trivial device-to-device copy wraps `::cuda::std::identity` in `::cuda::proclaim_copyable_arguments` so DeviceTransform can use UBLKCP (merged cleanly). cub `kernels/transform.cuh` belongs to hipCUB. - HIP counterpart: no change: performance-only. - test/ counterpart: none; testing/ counterpart: none. - Not compiled, tests not run (per human). Co-Authored-By: Claude <noreply@anthropic.com>
amd-jmahovsky
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 30, 2026
…roclaims copyable arguments Related upstream commit: 36ec00be03f Ensure non-trivial thrust::copy from D2D uses UBLKCP (NVIDIA/cccl#5954) Upstream: NVIDIA/cccl@36ec00b Related local port commit: 31847ac Related local parity commit: 713e047 713e047 left the proclaim_copyable_arguments wrapper out of the HIP backend. Add it, as upstream does for CUDA: the non-trivial branch of __copy::device_to_device in thrust/system/hip/detail/copy.h now passes _THRUST_LIBCXX::proclaim_copyable_arguments(_THRUST_STD::identity{}) to hip_rocprim::transform, so the transform may copy its arguments instead of reading them in place. Upstream needs no new include for this. Here copy.h and transform.h include each other, so copy.h includes __functional/address_stability.h itself. Not compiled, tests not run Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5955