Repository navigation
Drop Thrust mpl math - #5897
Merged
Merged
Drop Thrust mpl math#5897
Conversation
miscco
approved these changes
Sep 16, 2025
miscco
approved these changes
Sep 16, 2025
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
force-pushed
the
drop_mpl_math
branch
from
September 16, 2025 21:24
5864a5b to
e9f052c
Compare
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
force-pushed
the
drop_mpl_math
branch
from
September 17, 2025 09:41
fc0e7d9 to
bc4b5a8
Compare
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
force-pushed
the
drop_mpl_math
branch
from
September 17, 2025 17:55
bc4b5a8 to
4c68e77
Compare
bernhardmgruber
enabled auto-merge (squash)
September 18, 2025 21:03
Contributor
🥳 CI Workflow Results🟩 Finished in 3h 36m: Pass: 100%/159 | Total: 6d 04h | Max: 3h 34m | Hits: 70%/186335See results here. |
pciolkosz
pushed a commit
to pciolkosz/cccl
that referenced
this pull request
Sep 24, 2025
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 26, 2026
…/cccl#5897) Upstream: NVIDIA/cccl@bb71851 - `git rm thrust/detail/mpl/math.h`. - xor_combine_engine_max.h was rewritten to constexpr functions, using `_THRUST_STD` spelling. Its conflict came from the local include block; I used a single `_THRUST_STD_INCLUDE(algorithm)` in place of the `__algorithm/max.h`/`min.h` detail headers, which the `::std` fallback does not have. - system/cuda reduce_by_key/set_operations: mpl::min/max replaced by `::cuda::std::min/max` (conflict 1, took upstream). Dropped the unused mpl/math.h includes from scan_by_key/unique_by_key. - HIP counterpart: removed the unused `#include <thrust/detail/mpl/math.h>` from system/hip/detail/{scan_by_key,set_operations,unique_by_key}.h. No mpl::math uses remained. - test/ counterpart: git mv `test/test_metaprogramming.cpp` -> `test/test_xor_combine_engine_max.cpp`. It now has `TEST(XorCombineEngineMaxTests, TestLog2)` as static_asserts on `thrust::random::detail::log2`. The CMake registration "metaprogramming" was replaced by "xor_combine_engine_max". - testing/ counterpart: `git rm testing/metaprogramming.cu` and added upstream `testing/xor_combine_engine_max.cu`. Updated testing/CMakeLists.txt to match. - Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
amd-jmahovsky
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 28, 2026
…des in xor_combine_engine_max Related upstream commit: bb718514624 Drop Thrust mpl math (NVIDIA/cccl#5897) Related local port commit: 1a7094e Include _THRUST_STD_INCLUDE(__algorithm/max.h) and __algorithm/min.h instead of the <algorithm> and <type_traits> umbrella headers, as upstream (both granular headers exist in libhipcxx, which is now mandatory). The host <cstddef> include is kept for the unqualified size_t. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 29, 2026
…/cccl#5897) Upstream: NVIDIA/cccl@bb71851 - `git rm thrust/detail/mpl/math.h`. - xor_combine_engine_max.h was rewritten to constexpr functions, using `_THRUST_STD` spelling. Its conflict came from the local include block; I used a single `_THRUST_STD_INCLUDE(algorithm)` in place of the `__algorithm/max.h`/`min.h` detail headers, which the `::std` fallback does not have. - system/cuda reduce_by_key/set_operations: mpl::min/max replaced by `::cuda::std::min/max` (conflict 1, took upstream). Dropped the unused mpl/math.h includes from scan_by_key/unique_by_key. - HIP counterpart: removed the unused `#include <thrust/detail/mpl/math.h>` from system/hip/detail/{scan_by_key,set_operations,unique_by_key}.h. No mpl::math uses remained. - test/ counterpart: git mv `test/test_metaprogramming.cpp` -> `test/test_xor_combine_engine_max.cpp`. It now has `TEST(XorCombineEngineMaxTests, TestLog2)` as static_asserts on `thrust::random::detail::log2`. The CMake registration "metaprogramming" was replaced by "xor_combine_engine_max". - testing/ counterpart: `git rm testing/metaprogramming.cu` and added upstream `testing/xor_combine_engine_max.cu`. Updated testing/CMakeLists.txt to match. - Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 29, 2026
…/cccl#5897) Upstream: NVIDIA/cccl@bb71851 - `git rm thrust/detail/mpl/math.h`. - xor_combine_engine_max.h was rewritten to constexpr functions, using `_THRUST_STD` spelling. Its conflict came from the local include block; I used a single `_THRUST_STD_INCLUDE(algorithm)` in place of the `__algorithm/max.h`/`min.h` detail headers, which the `::std` fallback does not have. - system/cuda reduce_by_key/set_operations: mpl::min/max replaced by `::cuda::std::min/max` (conflict 1, took upstream). Dropped the unused mpl/math.h includes from scan_by_key/unique_by_key. - HIP counterpart: removed the unused `#include <thrust/detail/mpl/math.h>` from system/hip/detail/{scan_by_key,set_operations,unique_by_key}.h. No mpl::math uses remained. - test/ counterpart: git mv `test/test_metaprogramming.cpp` -> `test/test_xor_combine_engine_max.cpp`. It now has `TEST(XorCombineEngineMaxTests, TestLog2)` as static_asserts on `thrust::random::detail::log2`. The CMake registration "metaprogramming" was replaced by "xor_combine_engine_max". - testing/ counterpart: `git rm testing/metaprogramming.cu` and added upstream `testing/xor_combine_engine_max.cu`. Updated testing/CMakeLists.txt to match. - Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 29, 2026
…des in xor_combine_engine_max Related upstream commit: bb718514624 Drop Thrust mpl math (NVIDIA/cccl#5897) Related local port commit: 1a7094e Include _THRUST_STD_INCLUDE(__algorithm/max.h) and __algorithm/min.h instead of the <algorithm> and <type_traits> umbrella headers, as upstream (both granular headers exist in libhipcxx, which is now mandatory). The host <cstddef> include is kept for the unqualified size_t. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Naraenda
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 30, 2026
…/cccl#5897) Upstream: NVIDIA/cccl@bb71851 - `git rm thrust/detail/mpl/math.h`. - xor_combine_engine_max.h was rewritten to constexpr functions, using `_THRUST_STD` spelling. Its conflict came from the local include block; I used a single `_THRUST_STD_INCLUDE(algorithm)` in place of the `__algorithm/max.h`/`min.h` detail headers, which the `::std` fallback does not have. - system/cuda reduce_by_key/set_operations: mpl::min/max replaced by `::cuda::std::min/max` (conflict 1, took upstream). Dropped the unused mpl/math.h includes from scan_by_key/unique_by_key. - HIP counterpart: removed the unused `#include <thrust/detail/mpl/math.h>` from system/hip/detail/{scan_by_key,set_operations,unique_by_key}.h. No mpl::math uses remained. - test/ counterpart: git mv `test/test_metaprogramming.cpp` -> `test/test_xor_combine_engine_max.cpp`. It now has `TEST(XorCombineEngineMaxTests, TestLog2)` as static_asserts on `thrust::random::detail::log2`. The CMake registration "metaprogramming" was replaced by "xor_combine_engine_max". - testing/ counterpart: `git rm testing/metaprogramming.cu` and added upstream `testing/xor_combine_engine_max.cu`. Updated testing/CMakeLists.txt to match. - Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
Beanavil
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 30, 2026
…/cccl#5897) Upstream: NVIDIA/cccl@bb71851 - `git rm thrust/detail/mpl/math.h`. - xor_combine_engine_max.h was rewritten to constexpr functions, using `_THRUST_STD` spelling. Its conflict came from the local include block; I used a single `_THRUST_STD_INCLUDE(algorithm)` in place of the `__algorithm/max.h`/`min.h` detail headers, which the `::std` fallback does not have. - system/cuda reduce_by_key/set_operations: mpl::min/max replaced by `::cuda::std::min/max` (conflict 1, took upstream). Dropped the unused mpl/math.h includes from scan_by_key/unique_by_key. - HIP counterpart: removed the unused `#include <thrust/detail/mpl/math.h>` from system/hip/detail/{scan_by_key,set_operations,unique_by_key}.h. No mpl::math uses remained. - test/ counterpart: git mv `test/test_metaprogramming.cpp` -> `test/test_xor_combine_engine_max.cpp`. It now has `TEST(XorCombineEngineMaxTests, TestLog2)` as static_asserts on `thrust::random::detail::log2`. The CMake registration "metaprogramming" was replaced by "xor_combine_engine_max". - testing/ counterpart: `git rm testing/metaprogramming.cu` and added upstream `testing/xor_combine_engine_max.cu`. Updated testing/CMakeLists.txt to match. - Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
amd-jmahovsky
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 30, 2026
…des in xor_combine_engine_max Related upstream commit: bb718514624 Drop Thrust mpl math (NVIDIA/cccl#5897) Related local port commit: 1a7094e Include _THRUST_STD_INCLUDE(__algorithm/max.h) and __algorithm/min.h instead of the <algorithm> and <type_traits> umbrella headers, as upstream (both granular headers exist in libhipcxx, which is now mandatory). The host <cstddef> include is kept for the unqualified size_t. Not compiled, tests not run (per human) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.