Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace thrust::detail::integral_constant with libcudacxx implementation #561

Merged
merged 13 commits into from
Oct 17, 2023
Merged

Replace thrust::detail::integral_constant with libcudacxx implementation #561

merged 13 commits into from
Oct 17, 2023

Conversation

ZelboK
Copy link
Contributor

@ZelboK ZelboK commented Oct 13, 2023

Tests pass for thrust on clang++-16 cxx17 and 86 architecture.

integral_constant is currently relied on for a lot of the metaprogramming facilities, such as is_same. The implementation that currently exists can be replaced, which would also allow for other parts of type_traits to transition over to libcudacxx implementations.

@ZelboK ZelboK requested review from a team as code owners October 13, 2023 22:03
@ZelboK ZelboK requested review from gevtushenko and wmaxey and removed request for a team October 13, 2023 22:03
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 13, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ZelboK
Copy link
Contributor Author

ZelboK commented Oct 13, 2023

Need to undo formatting.

@ZelboK ZelboK changed the title Replace thrust::detail::integral_constant with libcudacxx implementation [DRAFT] Replace thrust::detail::integral_constant with libcudacxx implementation Oct 13, 2023
@ZelboK ZelboK changed the title [DRAFT] Replace thrust::detail::integral_constant with libcudacxx implementation Replace thrust::detail::integral_constant with libcudacxx implementation Oct 13, 2023
miscco
miscco approved these changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me 👍

@miscco
Copy link
Contributor

miscco commented Oct 14, 2023

/ok to test

@miscco
Copy link
Contributor

miscco commented Oct 14, 2023

/ok to test

@ZelboK ZelboK requested a review from a team as a code owner October 14, 2023 16:50
@miscco
Copy link
Contributor

miscco commented Oct 14, 2023

/ok to test

@ZelboK
Revert to use call operator again and introduce conditional back. Not…
c2e3f87 
… meant to be deleted, since cpp11 is supported.
@miscco
Copy link
Contributor

miscco commented Oct 15, 2023

/ok to test

@miscco
Copy link
Contributor

miscco commented Oct 16, 2023

/ok to test

@miscco
Copy link
Contributor

miscco commented Oct 16, 2023

@ZelboK I fixed a subtle issue with old MSVC

@miscco
Copy link
Contributor

miscco commented Oct 16, 2023

/ok to test

@miscco miscco merged commit b269438 into NVIDIA:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco

@gevtushenko gevtushenko

@wmaxey wmaxey

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZelboK @miscco