-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cub::BlockAdjacentDifference documentation #542
Conversation
Thanks a lot for finding and fixing those issues |
@miscco "tripping over" them might be a more appropriate description than "finding" them 😆 Happy to help |
@pauleonix could you please add [skip ci] to the commit message. We do not want to run CI for plain documentation changes |
Fix factual errors, typos, copy-paste-errors [skip ci]
[skip ci] Co-authored-by: Michael Schellenberger Costa <[email protected]>
66ae315
to
81e820e
Compare
@miscco Like this or rather at the beginning of the title? |
/ok to test |
I believe it does not matter, but lets see ;) |
[skip ci] Co-authored-by: Georgy Evtushenko <[email protected]>
/ok to test |
Fix factual errors, typos, copy-paste-errors
Description
closes #541
The documentation for
BlockAdjacentDifference
seemed very wonky to me both in formulation and in some of the example results provided for the example code snippets and even the order of arguments in one example. I tried correcting all flaws that I found (including some less important copy-paste mistakes and a typo) to the best of my knowledge both from reading the source code and trying it out on CompilerExplorer, but there might be more.This PR was corresponds to NVIDIA/cub#724 where @senior-zero asked me to reapply the changes here.
Checklist