Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable complex interop on MSVC #490

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Sep 26, 2023

currently we did not enable the interoperability of cuda::std::complex with std::complex for MSVC

Fix this to enable it for thrust::complex

@miscco miscco requested review from a team as code owners September 26, 2023 11:04
@miscco miscco requested review from ericniebler, alliepiper, elstehle and gevtushenko and removed request for a team September 26, 2023 11:04
currently we did not enable the interoperability of `cuda::std::complex` with `std::complex` for MSVC

Fix this to enable it for `thrust::complex`
@miscco miscco force-pushed the fix_thrust_complex_msvc branch from 28973fb to b462b43 Compare September 26, 2023 11:38
@miscco miscco requested a review from jrhemstad September 26, 2023 11:50
@@ -8,6 +8,7 @@
//===----------------------------------------------------------------------===//

// UNSUPPORTED: c++03, c++11, c++14
// UNSUPPORTED: msvc-19.16 && nvcc-11.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a merge conflict from the concurrent merge of sortable and msvc PR

@miscco miscco merged commit 7b1891f into NVIDIA:main Sep 26, 2023
@miscco miscco deleted the fix_thrust_complex_msvc branch September 26, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants