Enable complex interop on MSVC #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
requested review from
ericniebler,
alliepiper,
elstehle and
gevtushenko
and removed request for
a team
currently we did not enable the interoperability of `cuda::std::complex` with `std::complex` for MSVC Fix this to enable it for `thrust::complex`
miscco
force-pushed
the
fix_thrust_complex_msvc
branch
from
28973fb to
b462b43
Compare
miscco
commented
Sep 26, 2023
| @@ -8,6 +8,7 @@ | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| // UNSUPPORTED: c++03, c++11, c++14 | |||
| // UNSUPPORTED: msvc-19.16 && nvcc-11.1 | |||
There was a problem hiding this comment.
This is a merge conflict from the concurrent merge of sortable and msvc PR
elstehle
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently we did not enable the interoperability of
cuda::std::complexwithstd::complexfor MSVCFix this to enable it for
thrust::complex