Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

constexpr all the things #476

Merged
merged 2 commits into from
Sep 25, 2023
Merged

constexpr all the things #476

merged 2 commits into from
Sep 25, 2023

Conversation

pb-dseifert
Copy link
Contributor

Description

Make the CUB codebase constexpr consistent.

@pb-dseifert pb-dseifert requested review from a team as code owners September 23, 2023 13:12
@pb-dseifert pb-dseifert requested review from elstehle and wmaxey and removed request for a team September 23, 2023 13:12
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 23, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@jrhemstad
Copy link
Collaborator

/ok to test

@pb-dseifert pb-dseifert force-pushed the constexpr-all-the-things branch from d77bdf5 to 80b5d4d Compare September 23, 2023 15:19
@jrhemstad
Copy link
Collaborator

/ok to test

@pb-dseifert pb-dseifert force-pushed the constexpr-all-the-things branch from 80b5d4d to d8221ce Compare September 23, 2023 16:28
@pb-dseifert
Copy link
Contributor Author

@jrhemstad cleaned up the formatting

@jrhemstad
Copy link
Collaborator

/ok to test

@miscco
Copy link
Collaborator

miscco commented Sep 25, 2023

Thanks a lot for the contribution 🎉

I am sure Jason will be proud 😸

@miscco miscco merged commit 95e6634 into NVIDIA:main Sep 25, 2023
@pb-dseifert pb-dseifert deleted the constexpr-all-the-things branch September 26, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elstehle elstehle elstehle approved these changes

@miscco miscco miscco approved these changes

@wmaxey wmaxey Awaiting requested review from wmaxey wmaxey is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pb-dseifert @jrhemstad @miscco @elstehle