Avoid integer promotion warnings with MSVC #460
Merged
+23
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
requested review from
elstehle and
wmaxey
and removed request for
a team
It seems that MSVC introduces an integer promotion when calling a templated call operator, e.g. with `std::minus` We can work around this issue by explicitly passing in the type w want. See https://godbolt.org/z/b5qP86dTE
miscco
force-pushed
the
avoid_integer_promotion_adjacent_difference
branch
from
3b49095 to
81ad380
Compare
elstehle
approved these changes
Sep 20, 2023
jrhemstad
approved these changes
Sep 20, 2023
gevtushenko
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that MSVC introduces an integer promotion when calling a templated call operator, e.g. with
std::minusWe can work around this issue by explicitly passing in the type w want. See https://godbolt.org/z/b5qP86dTE
Fixes thrust build issues on MSVC