[libcu++] Try to avoid gcc misscompilation issues #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
requested review from
alliepiper and
griwes
and removed request for
a team
We experience gcc backend misscompilations in some of the thrust unit tests. Those are all tests that use an array of 3 elements. It seems the optimizer has some very volatile issues and often just increasing the range to 4 elements "solves" the issue
miscco
force-pushed
the
workaround_gcc_miscompilation
branch
from
6987eb3 to
187ca7f
Compare
gevtushenko
approved these changes
Sep 19, 2023
jrhemstad
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We experience gcc backend misscompilations in some of the thrust unit tests. Those are all tests that use an array of 3 elements. It seems the optimizer has some very volatile issues and often just increasing the range to 4 elements "solves" the issue