Run .devcontainer/launch.sh with bash + add error checking
#407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the script will be run with the user's shell, not bash.
Previously if an invalid combination was specified we would get errors from cp and sed, and then launch vscode anyway. Instead, check for existence of the devcontainer.json and exit, providing a useful error message, if it doesn't.
After the update to 12.2 containers, the example usage in launch.sh does not boot a valid container.
wence-
requested review from
jarmak-nv and
elstehle
and removed request for
a team
miscco
approved these changes
Sep 6, 2023
|
Thanks a lot for the contribution 🎉 |
jrhemstad
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Thanks @wence-!
Admittedly, I have been neglecting the launch.sh ever since I hit a roadblock in supporting custom CTK/host compiler combinations. I wrote up the status quo here: #126 (comment)
|
@wence- could you please add the We want to avoid running expensive GPU tests for pure infrastructure fixes. Any issues with the changes will be found by the CPU-only build tests |
This way, we get a useful early exit if some other command later in the script bails.
wence-
force-pushed
the
wence/fix/launch-error-checking
branch
from
1367fad to
ca806e0
Compare
Done, thanks! |
|
/ok to test |
|
Thanks a lot for fixing the launch script 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the shebang line to work, it must be the first line of the file (not the second as at present).
While here, add
set -euo pipefailand notice, and provide, a useful error message if we've requested a CTK + compiler combo that doesn't have a prebaked devcontainer.json. Previously, we would get errors fromcpandsedand then launch vscode anyway.A partial step towards #126, in that unknown devcontainer combinations are now at least noticed.
Checklist