-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dtype handling. #4004
Merged
tpn
merged 4 commits into
NVIDIA:main
from
tpn:3914-accept-numpy-types-in-cuda-cooperative
Mar 4, 2025
Merged
Improve dtype handling. #4004
tpn
merged 4 commits into
NVIDIA:main
from
tpn:3914-accept-numpy-types-in-cuda-cooperative
Mar 4, 2025
+291
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c995236
to
1f2fa7d
Compare
🟩 CI finished in 1h 00m: Pass: 100%/1 | Total: 1h 00m | Avg: 1h 00m | Max: 1h 00m
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
CUDA Experimental | |
+/- | python |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
CUDA Experimental | |
+/- | python |
CCCL C Parallel Library | |
Catch2Helper |
🏃 Runner counts (total jobs: 1)
# | Runner |
---|---|
1 | linux-amd64-gpu-rtx2080-latest-1 |
brycelelbach
requested changes
Mar 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for lowering int
->int32
and float
->float32
python/cuda_cooperative/cuda/cooperative/experimental/_common.py
Outdated
Show resolved
Hide resolved
python/cuda_cooperative/cuda/cooperative/experimental/block/_block_scan.py
Show resolved
Hide resolved
Add supporting tests.
1f2fa7d
to
cf2f269
Compare
4835992
to
c85b70a
Compare
brycelelbach
approved these changes
Mar 4, 2025
🟩 CI finished in 58m 48s: Pass: 100%/1 | Total: 58m 48s | Avg: 58m 48s | Max: 58m 48s
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
CUDA Experimental | |
+/- | python |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
CUDA Experimental | |
+/- | python |
CCCL C Parallel Library | |
Catch2Helper |
🏃 Runner counts (total jobs: 1)
# | Runner |
---|---|
1 | linux-amd64-gpu-rtx2080-latest-1 |
rwgk
approved these changes
Mar 4, 2025
This was referenced Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves dtype handling for
cuda.cooperative
routines, allowing a much wider range of values to be passed to any of the Pythonic CUB routines that accept a dtype param. Per thenormalize_dtype_param()
docstring, the logic is as follows:This is for #3914.