Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port DeviceAdjacentDifference::SubtractRight tests to catch2 #390

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Sep 1, 2023

This ports our adjacent_difference tests from the old test setup to catch2

Addresses #87

@miscco miscco requested review from a team as code owners September 1, 2023 12:10
@miscco miscco requested review from elstehle and alliepiper and removed request for a team September 1, 2023 12:10
@miscco miscco force-pushed the catch2_adjacent_difference branch from 5f1fb64 to 0d86291 Compare September 6, 2023 11:15
@miscco
Copy link
Contributor Author

miscco commented Sep 6, 2023

@senior-zero I have adopted your comments.

That said, I went for the simplification of the old tests to only add large indexes and invocation count tests for the AdjacentSubtract{Left, Right}Copy variants, as those do not require to allocate much memory.

Shout if you need the in place version to be also tested

@miscco miscco requested a review from gevtushenko September 6, 2023 11:17
@miscco miscco merged commit 3322fac into NVIDIA:main Sep 8, 2023
@miscco miscco deleted the catch2_adjacent_difference branch September 8, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants