Port DeviceAdjacentDifference::SubtractRight tests to catch2
#390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
requested review from
elstehle and
alliepiper
and removed request for
a team
gevtushenko
reviewed
Sep 5, 2023
cub/test/catch2_test_device_adjacent_difference_substract_left.cu
Outdated
Show resolved
Hide resolved
miscco
force-pushed
the
catch2_adjacent_difference
branch
from
5f1fb64 to
0d86291
Compare
|
@senior-zero I have adopted your comments. That said, I went for the simplification of the old tests to only add large indexes and invocation count tests for the Shout if you need the in place version to be also tested |
gevtushenko
approved these changes
Sep 6, 2023
cub/test/catch2_test_device_adjacent_difference_substract_left.cu
Outdated
Show resolved
Hide resolved
cub/test/catch2_test_device_adjacent_difference_substract_left.cu
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports our
adjacent_differencetests from the old test setup to catch2Addresses #87