-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH Infra: project automation and issue template fixes #297
GH Infra: project automation and issue template fixes #297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test
After a bunch of digging and testing here's the results:
This largely achieves the same results, except linked issues do not follow the status. We could edit https://github.com/NVIDIA/cccl/blob/main/.github/workflows/project_automation_sync_pr_issues.yml to be on Unfortunately, the default github token cannot trigger actions, otherwise the conversion to draft would re-trigger this action and make the challenges moot. |
* Change from App auth to an org secret * Fix labels in issue templates * Revert app secret method, not the root cause * Move draft conversion, exit if pull_request_review
Description
closes #296
closes #263
This PR changes the project automation workflows from using the GitHub app authentication to an org secret -
this should resolve the failures during thepull_request_review
action trigger.It does not. We could do a secondary workflow as a workaround, but it's too hack-y for me. https://stackoverflow.com/questions/67247752/how-to-use-secret-in-pull-request-review-similar-to-pull-request-target
Will update the logic so it still converts to draft (gh token can get pull_request
write
so that should be fine) and we'll just manually have to re-set to in_progress. I could add forpull_request_target
onsynchronize
it checks if its in draft and sets to in progress so after a commit is pushed it will check and auto-update. My worry is it will run too often.It also fixes the issue template labels so they should be correctly pre-assigned.
Checklist