Replace thrust::complex with cuda::std::complex
#260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some notable differences though. thrust::complex has been a bit more lenient when determining the type of arithmetic operations. That said, I believe being more strict is actually a feature not a bug
miscco
requested review from
ericniebler,
gevtushenko and
elstehle
and removed request for
a team
miscco
commented
Jul 24, 2023
| @@ -1781,6 +1783,57 @@ operator<<(basic_ostream<_CharT, _Traits>& __os, const complex<_Tp>& __x) | |||
| return __os << __s.str(); | |||
| } | |||
| #endif // !_LIBCUDACXX_HAS_NO_LOCALIZATION | |||
| #else // ^^^ !__cuda_std__ ^^^ / vvv __cuda_std__ | |||
There was a problem hiding this comment.
Those changes might be controversial as we are pulling in quite some machinery. Thoughts?
miscco
added
feature request
miscco
changed the title
thrust::complex with std::complexthrust::complex with cuda::std::complex
gevtushenko
requested changes
Jul 25, 2023
Comment on lines
-59
to
-66
| template <typename T0, typename T1> | ||
| __host__ __device__ | ||
| complex<typename detail::promoted_numerical_type<T0, T1>::type> | ||
| operator-(const complex<T0>& x, const complex<T1>& y) | ||
| { | ||
| typedef typename detail::promoted_numerical_type<T0, T1>::type T; | ||
| return complex<T>(x.real() - y.real(), x.imag() - y.imag()); | ||
| } |
There was a problem hiding this comment.
The following code used to work, but now it doesn't:
thrust::complex<float> a;
thrust::complex<double> b;
auto c = a + b;I think we need to keep this overload and maybe mark it as deprecated. Same with other operators.
Comment on lines
-49
to
-56
| template <typename T0, typename T1> | ||
| __host__ __device__ | ||
| complex<typename detail::promoted_numerical_type<T0, T1>::type> | ||
| operator+(const T0& x, const complex<T1>& y) | ||
| { | ||
| typedef typename detail::promoted_numerical_type<T0, T1>::type T; | ||
| return complex<T>(x + y.real(), y.imag()); | ||
| } |
There was a problem hiding this comment.
The following code used to work, but now it doesn't:
float a = 84;
thrust::complex<double> b(42, 42);
auto c = a + b;I think we need to keep this overload and maybe mark it as deprecated. Same with other operators.
| // As std::hypot is only C++11 we have to use the C interface | ||
| template <typename T> | ||
| __host__ __device__ | ||
| T abs(const complex<T>& z) |
There was a problem hiding this comment.
The following code used to work, now it doesn't:
thrust::complex<double> a;
auto b = thrust::abs(a);|
|
||
| template <typename T> | ||
| __host__ __device__ | ||
| T arg(const complex<T>& z) |
There was a problem hiding this comment.
The following code used to work, now it doesn't:
thrust::complex<double> a;
auto b = thrust::arg(a);
2 tasks
1 task
|
Dropping in favor of #454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some notable differences though. thrust::complex has been a
bit more lenient when determining the type of arithmetic operations.
That said, I believe being more strict is actually a feature not a bug