-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate packages and install rules #2456
Merged
alliepiper
merged 6 commits into
NVIDIA:main
from
alliepiper:packages_and_install_rules
Sep 25, 2024
Merged
Consolidate packages and install rules #2456
alliepiper
merged 6 commits into
NVIDIA:main
from
alliepiper:packages_and_install_rules
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests check that consumers can add_subdirectory(cccl/cub) add_subdirectory(cccl/thrust) to add Thrust or CUB to their build. This hasn't been sensible or supported since we migrated to the monorepo. Now that we're moving shared CMake infra to the CCCL, these tests are finally actually failing.
… helper to reduce redundancy.
These tests are redundant with CCCL-level tests, and no longer function now that install rules are centralized at the top level.
miscco
approved these changes
Sep 25, 2024
🟩 CI finished in 1h 59m: Pass: 100%/368 | Total: 6d 02h | Avg: 23m 50s | Max: 1h 09m | Hits: 99%/25663
|
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 368)
# | Runner |
---|---|
297 | linux-amd64-cpu16 |
28 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All CMake packages are moved to
cccl/lib/cmake/{project}
.All install rules are located under
cccl/cmake/install
.Various helper functions that eliminate redundant code have been added and documented.
Several obsolete tests were removed. These tested packaging and install rules at the project level and are redundant with similar tests at the
cccl
level.