-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not include our own string.h file #2444
Merged
Merged
+3
−197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That might conflict with the host standard library
griwes
approved these changes
Sep 20, 2024
🟩 CI finished in 1h 56m: Pass: 100%/364 | Total: 7d 22h | Avg: 31m 26s | Max: 1h 23m | Hits: 32%/25655
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 364)
# | Runner |
---|---|
297 | linux-amd64-cpu16 |
28 | linux-arm64-cpu16 |
24 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
rwgk
pushed a commit
to rwgk/cccl
that referenced
this pull request
Sep 24, 2024
That might conflict with the host standard library
miscco
added a commit
that referenced
this pull request
Sep 30, 2024
Loading
Loading status checks…
…ore Compute Libraries`. (#2447) * Do not include our own string.h file (#2444) That might conflict with the host standard library * Programmatically (`sed`) replace `CUDA C++ Core Libraries` with CUDA Core Compute Libraries`. NO MANUAL CHANGES. Command used: ``` for fn in `git grep 'CUDA C++ Core Libraries' | cut -d':' -f1 | uniq`; do sed -i .bak 's/CUDA C++ Core Libraries/CUDA Core Compute Libraries/g' $fn; done ``` * Extend `=======================` line in .rst file to match new name. * Revert changes in all .cuh, .cu, .h, .cpp files. Rationale: These files actually have a C++-specific license. It's left for later to change the license and the notices together. * Revert changes in docs/ subdirectory. --------- Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
gevtushenko
pushed a commit
that referenced
this pull request
Oct 4, 2024
Loading
Loading status checks…
…2429) * Brute force experiment: Which tests fail after adding an `assert False`? * Do not include our own string.h file (#2444) That might conflict with the host standard library * Add `_dtype_validation()` in python/cuda_parallel/cuda/parallel/experimental/__init__.py and fix bug in python/cuda_parallel/tests/test_reduce_api.py * Add `test_device_reduce_dtype_mismatch()`. Capture `dtype`s only in ctor (not entire arrays). * Undo change in .gitignore * Move `min_op()` back into `test_device_reduce_success()` to unbreak sphinx documentation. Also fix existing typo. * Move `test_device_reduce_dtype_mismatch()` from test_reduce_api.py to test_reduce.py * Add TODO POINTER vs ITERATOR --------- Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
rwgk
added a commit
that referenced
this pull request
Oct 14, 2024
* Do not include our own string.h file (#2444) That might conflict with the host standard library * Add missing `` in docs/cub/index.rst * Very minor grammar fix in docs/cub/index.rst * Remove outdated "Getting The Thrust Source Code" section. * Fix TEST_THRUST_PATH in c/parallel/test/CMakeLists.txt (looks like a copy-paste-forgot-to-modify-oversight) * Remove a stray semicolon in c/parallel/src/reduce.cu (functionally inconsequential). * Fix a memory leak in c/parallel/test/c2h.h (this leak is only in a test and most likely not critical at all). --------- Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
caugonnet
pushed a commit
to caugonnet/cccl
that referenced
this pull request
Oct 16, 2024
* Do not include our own string.h file (NVIDIA#2444) That might conflict with the host standard library * Add missing `` in docs/cub/index.rst * Very minor grammar fix in docs/cub/index.rst * Remove outdated "Getting The Thrust Source Code" section. * Fix TEST_THRUST_PATH in c/parallel/test/CMakeLists.txt (looks like a copy-paste-forgot-to-modify-oversight) * Remove a stray semicolon in c/parallel/src/reduce.cu (functionally inconsequential). * Fix a memory leak in c/parallel/test/c2h.h (this leak is only in a test and most likely not critical at all). --------- Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That might conflict with the host standard library