Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make any_resource emplacable #2425

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Make any_resource emplacable #2425

merged 6 commits into from
Sep 19, 2024
+321 −20

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Sep 18, 2024

We want to be able to directly emplace a resource inside an any_resource

This adds a constructor that takes a tag type and convenience functions make_any_resource

While we are at it also add tests for any_async_resource

@miscco miscco requested review from a team as code owners September 18, 2024 11:33
@miscco miscco added feature request New feature or request. CUDA Next Feature intended for the Cuda Next experimental library labels Sep 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

🟨 CI finished in 4h 01m: Pass: 96%/58 | Total: 3h 14m | Avg: 3m 21s | Max: 22m 30s

  • 🟨 cudax: Pass: 96%/58 | Total: 3h 14m | Avg: 3m 21s | Max: 22m 30s

     
    🔍 cpu: amd64 🔍
  🔍 amd64              Pass:  96%/54  | Total:  3h 05m | Avg:  3m 25s | Max: 22m 30s
  🟩 arm64              Pass: 100%/4   | Total:  9m 48s | Avg:  2m 27s | Max:  2m 35s
🚨 cxx_family: MSVC 🚨
  🟩 Clang              Pass: 100%/34  | Total:  1h 34m | Avg:  2m 46s | Max:  4m 36s
  🟩 GCC                Pass: 100%/22  | Total:  1h 00m | Avg:  2m 44s | Max:  4m 06s
  🔥 MSVC               Pass:   0%/2   | Total: 40m 04s | Avg: 20m 02s | Max: 22m 30s
🔍 jobs: Build 🔍
  🔍 Build              Pass:  96%/50  | Total:  2h 42m | Avg:  3m 15s | Max: 22m 30s
  🟩 Test               Pass: 100%/8   | Total: 32m 13s | Avg:  4m 01s | Max:  4m 36s
🔍 std: 20 🔍
  🟩 17                 Pass: 100%/32  | Total:  1h 27m | Avg:  2m 44s | Max:  4m 27s
  🔍 20                 Pass:  92%/26  | Total:  1h 47m | Avg:  4m 07s | Max: 22m 30s
🟨 cxx
  🟩 Clang9             Pass: 100%/2   | Total:  5m 20s | Avg:  2m 40s | Max:  2m 47s
  🟩 Clang10            Pass: 100%/2   | Total:  5m 18s | Avg:  2m 39s | Max:  2m 48s
  🟩 Clang11            Pass: 100%/4   | Total:  9m 58s | Avg:  2m 29s | Max:  2m 33s
  🟩 Clang12            Pass: 100%/4   | Total: 10m 19s | Avg:  2m 34s | Max:  2m 52s
  🟩 Clang13            Pass: 100%/4   | Total: 10m 34s | Avg:  2m 38s | Max:  3m 02s
  🟩 Clang14            Pass: 100%/6   | Total: 18m 41s | Avg:  3m 06s | Max:  3m 57s
  🟩 Clang15            Pass: 100%/2   | Total:  5m 02s | Avg:  2m 31s | Max:  2m 32s
  🟩 Clang16            Pass: 100%/4   | Total:  9m 45s | Avg:  2m 26s | Max:  2m 34s
  🟩 Clang17            Pass: 100%/2   | Total:  5m 10s | Avg:  2m 35s | Max:  2m 37s
  🟩 Clang18            Pass: 100%/4   | Total: 14m 13s | Avg:  3m 33s | Max:  4m 36s
  🟩 GCC9               Pass: 100%/2   | Total:  4m 48s | Avg:  2m 24s | Max:  2m 32s
  🟩 GCC10              Pass: 100%/4   | Total: 10m 09s | Avg:  2m 32s | Max:  2m 37s
  🟩 GCC11              Pass: 100%/4   | Total:  9m 40s | Avg:  2m 25s | Max:  2m 33s
  🟩 GCC12              Pass: 100%/9   | Total: 28m 25s | Avg:  3m 09s | Max:  4m 06s
  🟩 GCC13              Pass: 100%/3   | Total:  7m 23s | Avg:  2m 27s | Max:  2m 35s
  🟥 MSVC14.36          Pass:   0%/1   | Total: 17m 34s | Avg: 17m 34s | Max: 17m 34s
  🟥 MSVC14.39          Pass:   0%/1   | Total: 22m 30s | Avg: 22m 30s | Max: 22m 30s
🟨 cudacxx_family
  🟨 nvcc               Pass:  96%/58  | Total:  3h 14m | Avg:  3m 21s | Max: 22m 30s
🟨 gpu
  🟨 v100               Pass:  96%/58  | Total:  3h 14m | Avg:  3m 21s | Max: 22m 30s
🟨 ctk
  🟨 12.0               Pass:  95%/23  | Total:  1h 19m | Avg:  3m 27s | Max: 17m 34s
  🟨 12.6               Pass:  97%/35  | Total:  1h 55m | Avg:  3m 17s | Max: 22m 30s
🟨 cudacxx
  🟨 nvcc12.0           Pass:  95%/23  | Total:  1h 19m | Avg:  3m 27s | Max: 17m 34s
  🟨 nvcc12.6           Pass:  97%/35  | Total:  1h 55m | Avg:  3m 17s | Max: 22m 30s
🟩 sm
  🟩 90                 Pass: 100%/1   | Total:  2m 27s | Avg:  2m 27s | Max:  2m 27s
  🟩 90a                Pass: 100%/1   | Total:  2m 17s | Avg:  2m 17s | Max:  2m 17s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
pycuda
CUDA C Core Library

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
pycuda
CUDA C Core Library

🏃‍ Runner counts (total jobs: 58)
# Runner
44 linux-amd64-cpu16
8 linux-amd64-gpu-v100-latest-1
4 linux-arm64-cpu16
2 windows-amd64-cpu16

@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 13m 05s: Pass: 100%/58 | Total: 2h 38m | Avg: 2m 43s | Max: 11m 11s | Hits: 80%/210

  • 🟩 cudax: Pass: 100%/58 | Total: 2h 38m | Avg: 2m 43s | Max: 11m 11s | Hits: 80%/210 

    🟩 cpu
  🟩 amd64              Pass: 100%/54  | Total:  2h 30m | Avg:  2m 47s | Max: 11m 11s | Hits:  80%/210   
  🟩 arm64              Pass: 100%/4   | Total:  7m 28s | Avg:  1m 52s | Max:  1m 55s
🟩 ctk
  🟩 12.0               Pass: 100%/23  | Total:  1h 04m | Avg:  2m 48s | Max: 11m 11s | Hits:  80%/105   
  🟩 12.6               Pass: 100%/35  | Total:  1h 33m | Avg:  2m 40s | Max: 10m 46s | Hits:  80%/105   
🟩 cudacxx
  🟩 nvcc12.0           Pass: 100%/23  | Total:  1h 04m | Avg:  2m 48s | Max: 11m 11s | Hits:  80%/105   
  🟩 nvcc12.6           Pass: 100%/35  | Total:  1h 33m | Avg:  2m 40s | Max: 10m 46s | Hits:  80%/105   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/58  | Total:  2h 38m | Avg:  2m 43s | Max: 11m 11s | Hits:  80%/210   
🟩 cxx
  🟩 Clang9             Pass: 100%/2   | Total:  4m 40s | Avg:  2m 20s | Max:  2m 29s
  🟩 Clang10            Pass: 100%/2   | Total:  4m 37s | Avg:  2m 18s | Max:  2m 44s
  🟩 Clang11            Pass: 100%/4   | Total:  8m 57s | Avg:  2m 14s | Max:  2m 32s
  🟩 Clang12            Pass: 100%/4   | Total:  8m 43s | Avg:  2m 10s | Max:  2m 29s
  🟩 Clang13            Pass: 100%/4   | Total:  8m 49s | Avg:  2m 12s | Max:  2m 24s
  🟩 Clang14            Pass: 100%/6   | Total: 16m 29s | Avg:  2m 44s | Max:  3m 57s
  🟩 Clang15            Pass: 100%/2   | Total:  4m 11s | Avg:  2m 05s | Max:  2m 08s
  🟩 Clang16            Pass: 100%/4   | Total:  7m 53s | Avg:  1m 58s | Max:  2m 08s
  🟩 Clang17            Pass: 100%/2   | Total:  4m 13s | Avg:  2m 06s | Max:  2m 08s
  🟩 Clang18            Pass: 100%/4   | Total: 13m 56s | Avg:  3m 29s | Max:  4m 31s
  🟩 GCC9               Pass: 100%/2   | Total:  3m 56s | Avg:  1m 58s | Max:  2m 10s
  🟩 GCC10              Pass: 100%/4   | Total:  8m 28s | Avg:  2m 07s | Max:  2m 27s
  🟩 GCC11              Pass: 100%/4   | Total:  8m 48s | Avg:  2m 12s | Max:  2m 43s
  🟩 GCC12              Pass: 100%/9   | Total: 26m 43s | Avg:  2m 58s | Max:  3m 59s
  🟩 GCC13              Pass: 100%/3   | Total:  5m 47s | Avg:  1m 55s | Max:  2m 00s
  🟩 MSVC14.36          Pass: 100%/1   | Total: 11m 11s | Avg: 11m 11s | Max: 11m 11s | Hits:  80%/105   
  🟩 MSVC14.39          Pass: 100%/1   | Total: 10m 46s | Avg: 10m 46s | Max: 10m 46s | Hits:  80%/105   
🟩 cxx_family
  🟩 Clang              Pass: 100%/34  | Total:  1h 22m | Avg:  2m 25s | Max:  4m 31s
  🟩 GCC                Pass: 100%/22  | Total: 53m 42s | Avg:  2m 26s | Max:  3m 59s
  🟩 MSVC               Pass: 100%/2   | Total: 21m 57s | Avg: 10m 58s | Max: 11m 11s | Hits:  80%/210   
🟩 gpu
  🟩 v100               Pass: 100%/58  | Total:  2h 38m | Avg:  2m 43s | Max: 11m 11s | Hits:  80%/210   
🟩 jobs
  🟩 Build              Pass: 100%/50  | Total:  2h 05m | Avg:  2m 30s | Max: 11m 11s | Hits:  80%/210   
  🟩 Test               Pass: 100%/8   | Total: 32m 26s | Avg:  4m 03s | Max:  4m 31s
🟩 sm
  🟩 90                 Pass: 100%/1   | Total:  2m 00s | Avg:  2m 00s | Max:  2m 00s
  🟩 90a                Pass: 100%/1   | Total:  2m 00s | Avg:  2m 00s | Max:  2m 00s
🟩 std
  🟩 17                 Pass: 100%/32  | Total:  1h 16m | Avg:  2m 23s | Max:  4m 25s
  🟩 20                 Pass: 100%/26  | Total:  1h 21m | Avg:  3m 08s | Max: 11m 11s | Hits:  80%/210

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
pycuda
CUDA C Core Library

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
pycuda
CUDA C Core Library

🏃‍ Runner counts (total jobs: 58)
# Runner
44 linux-amd64-cpu16
8 linux-amd64-gpu-v100-latest-1
4 linux-arm64-cpu16
2 windows-amd64-cpu16

@miscco miscco force-pushed the any_resource_constructor branch from 0a30054 to 55b6e82 Compare September 19, 2024 15:52
@alliepiper
Copy link
Contributor

FYI: Merging in main to use new, smaller PR matrix.

@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 18m 25s: Pass: 100%/52 | Total: 2h 15m | Avg: 2m 36s | Max: 11m 04s | Hits: 80%/210

  • 🟩 cudax: Pass: 100%/52 | Total: 2h 15m | Avg: 2m 36s | Max: 11m 04s | Hits: 80%/210 

    🟩 cpu
  🟩 amd64              Pass: 100%/48  | Total:  2h 07m | Avg:  2m 39s | Max: 11m 04s | Hits:  80%/210   
  🟩 arm64              Pass: 100%/4   | Total:  8m 27s | Avg:  2m 06s | Max:  2m 22s
🟩 ctk
  🟩 12.0               Pass: 100%/19  | Total: 51m 18s | Avg:  2m 42s | Max: 11m 04s | Hits:  80%/105   
  🟩 12.6               Pass: 100%/33  | Total:  1h 24m | Avg:  2m 33s | Max: 10m 39s | Hits:  80%/105   
🟩 cudacxx
  🟩 nvcc12.0           Pass: 100%/19  | Total: 51m 18s | Avg:  2m 42s | Max: 11m 04s | Hits:  80%/105   
  🟩 nvcc12.6           Pass: 100%/33  | Total:  1h 24m | Avg:  2m 33s | Max: 10m 39s | Hits:  80%/105   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/52  | Total:  2h 15m | Avg:  2m 36s | Max: 11m 04s | Hits:  80%/210   
🟩 cxx
  🟩 Clang9             Pass: 100%/2   | Total:  4m 14s | Avg:  2m 07s | Max:  2m 12s
  🟩 Clang10            Pass: 100%/2   | Total:  4m 08s | Avg:  2m 04s | Max:  2m 13s
  🟩 Clang11            Pass: 100%/4   | Total:  8m 06s | Avg:  2m 01s | Max:  2m 07s
  🟩 Clang12            Pass: 100%/4   | Total:  8m 13s | Avg:  2m 03s | Max:  2m 07s
  🟩 Clang13            Pass: 100%/4   | Total:  8m 35s | Avg:  2m 08s | Max:  2m 20s
  🟩 Clang14            Pass: 100%/4   | Total: 10m 45s | Avg:  2m 41s | Max:  4m 22s
  🟩 Clang15            Pass: 100%/2   | Total:  4m 04s | Avg:  2m 02s | Max:  2m 03s
  🟩 Clang16            Pass: 100%/4   | Total:  8m 42s | Avg:  2m 10s | Max:  2m 22s
  🟩 Clang17            Pass: 100%/2   | Total:  4m 32s | Avg:  2m 16s | Max:  2m 17s
  🟩 Clang18            Pass: 100%/2   | Total:  6m 39s | Avg:  3m 19s | Max:  4m 31s
  🟩 GCC9               Pass: 100%/2   | Total:  3m 43s | Avg:  1m 51s | Max:  1m 58s
  🟩 GCC10              Pass: 100%/4   | Total:  7m 42s | Avg:  1m 55s | Max:  2m 04s
  🟩 GCC11              Pass: 100%/4   | Total:  7m 43s | Avg:  1m 55s | Max:  1m 59s
  🟩 GCC12              Pass: 100%/7   | Total: 20m 42s | Avg:  2m 57s | Max:  4m 16s
  🟩 GCC13              Pass: 100%/3   | Total:  6m 15s | Avg:  2m 05s | Max:  2m 15s
  🟩 MSVC14.36          Pass: 100%/1   | Total: 11m 04s | Avg: 11m 04s | Max: 11m 04s | Hits:  80%/105   
  🟩 MSVC14.39          Pass: 100%/1   | Total: 10m 39s | Avg: 10m 39s | Max: 10m 39s | Hits:  80%/105   
🟩 cxx_family
  🟩 Clang              Pass: 100%/30  | Total:  1h 07m | Avg:  2m 15s | Max:  4m 31s
  🟩 GCC                Pass: 100%/20  | Total: 46m 05s | Avg:  2m 18s | Max:  4m 16s
  🟩 MSVC               Pass: 100%/2   | Total: 21m 43s | Avg: 10m 51s | Max: 11m 04s | Hits:  80%/210   
🟩 gpu
  🟩 v100               Pass: 100%/52  | Total:  2h 15m | Avg:  2m 36s | Max: 11m 04s | Hits:  80%/210   
🟩 jobs
  🟩 Build              Pass: 100%/47  | Total:  1h 54m | Avg:  2m 26s | Max: 11m 04s | Hits:  80%/210   
  🟩 Test               Pass: 100%/5   | Total: 21m 18s | Avg:  4m 15s | Max:  4m 31s
🟩 sm
  🟩 90                 Pass: 100%/1   | Total:  1m 55s | Avg:  1m 55s | Max:  1m 55s
  🟩 90a                Pass: 100%/1   | Total:  2m 02s | Avg:  2m 02s | Max:  2m 02s
🟩 std
  🟩 17                 Pass: 100%/28  | Total:  1h 01m | Avg:  2m 12s | Max:  4m 16s
  🟩 20                 Pass: 100%/24  | Total:  1h 14m | Avg:  3m 05s | Max: 11m 04s | Hits:  80%/210

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
pycuda
CUDA C Core Library

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
pycuda
CUDA C Core Library

🏃‍ Runner counts (total jobs: 52)
# Runner
41 linux-amd64-cpu16
5 linux-amd64-gpu-v100-latest-1
4 linux-arm64-cpu16
2 windows-amd64-cpu16

@miscco miscco enabled auto-merge (squash) September 19, 2024 18:32
@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 18m 13s: Pass: 100%/52 | Total: 3h 44m | Avg: 4m 19s | Max: 13m 37s | Hits: 83%/214

  • 🟩 cudax: Pass: 100%/52 | Total: 3h 44m | Avg: 4m 19s | Max: 13m 37s | Hits: 83%/214 

    🟩 cpu
  🟩 amd64              Pass: 100%/48  | Total:  2h 57m | Avg:  3m 41s | Max: 11m 36s | Hits:  83%/214   
  🟩 arm64              Pass: 100%/4   | Total: 47m 12s | Avg: 11m 48s | Max: 13m 37s
🟩 ctk
  🟩 12.0               Pass: 100%/19  | Total:  1h 07m | Avg:  3m 34s | Max: 11m 00s | Hits:  83%/107   
  🟩 12.6               Pass: 100%/33  | Total:  2h 36m | Avg:  4m 44s | Max: 13m 37s | Hits:  83%/107   
🟩 cudacxx
  🟩 nvcc12.0           Pass: 100%/19  | Total:  1h 07m | Avg:  3m 34s | Max: 11m 00s | Hits:  83%/107   
  🟩 nvcc12.6           Pass: 100%/33  | Total:  2h 36m | Avg:  4m 44s | Max: 13m 37s | Hits:  83%/107   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/52  | Total:  3h 44m | Avg:  4m 19s | Max: 13m 37s | Hits:  83%/214   
🟩 cxx
  🟩 Clang9             Pass: 100%/2   | Total:  5m 16s | Avg:  2m 38s | Max:  2m 41s
  🟩 Clang10            Pass: 100%/2   | Total:  5m 19s | Avg:  2m 39s | Max:  2m 42s
  🟩 Clang11            Pass: 100%/4   | Total: 10m 27s | Avg:  2m 36s | Max:  2m 54s
  🟩 Clang12            Pass: 100%/4   | Total:  9m 52s | Avg:  2m 28s | Max:  2m 35s
  🟩 Clang13            Pass: 100%/4   | Total: 10m 19s | Avg:  2m 34s | Max:  2m 41s
  🟩 Clang14            Pass: 100%/4   | Total: 11m 55s | Avg:  2m 58s | Max:  4m 30s
  🟩 Clang15            Pass: 100%/2   | Total:  5m 16s | Avg:  2m 38s | Max:  2m 44s
  🟩 Clang16            Pass: 100%/4   | Total: 31m 04s | Avg:  7m 46s | Max: 13m 36s
  🟩 Clang17            Pass: 100%/2   | Total:  5m 09s | Avg:  2m 34s | Max:  2m 35s
  🟩 Clang18            Pass: 100%/2   | Total:  7m 12s | Avg:  3m 36s | Max:  4m 33s
  🟩 GCC9               Pass: 100%/2   | Total:  5m 05s | Avg:  2m 32s | Max:  2m 45s
  🟩 GCC10              Pass: 100%/4   | Total:  9m 30s | Avg:  2m 22s | Max:  2m 40s
  🟩 GCC11              Pass: 100%/4   | Total: 29m 41s | Avg:  7m 25s | Max: 10m 33s
  🟩 GCC12              Pass: 100%/7   | Total: 26m 32s | Avg:  3m 47s | Max:  5m 21s
  🟩 GCC13              Pass: 100%/3   | Total: 29m 27s | Avg:  9m 49s | Max: 13m 37s
  🟩 MSVC14.36          Pass: 100%/1   | Total: 11m 00s | Avg: 11m 00s | Max: 11m 00s | Hits:  83%/107   
  🟩 MSVC14.39          Pass: 100%/1   | Total: 11m 36s | Avg: 11m 36s | Max: 11m 36s | Hits:  83%/107   
🟩 cxx_family
  🟩 Clang              Pass: 100%/30  | Total:  1h 41m | Avg:  3m 23s | Max: 13m 36s
  🟩 GCC                Pass: 100%/20  | Total:  1h 40m | Avg:  5m 00s | Max: 13m 37s
  🟩 MSVC               Pass: 100%/2   | Total: 22m 36s | Avg: 11m 18s | Max: 11m 36s | Hits:  83%/214   
🟩 gpu
  🟩 v100               Pass: 100%/52  | Total:  3h 44m | Avg:  4m 19s | Max: 13m 37s | Hits:  83%/214   
🟩 jobs
  🟩 Build              Pass: 100%/47  | Total:  3h 23m | Avg:  4m 19s | Max: 13m 37s | Hits:  83%/214   
  🟩 Test               Pass: 100%/5   | Total: 21m 10s | Avg:  4m 14s | Max:  4m 33s
🟩 sm
  🟩 90                 Pass: 100%/1   | Total:  5m 21s | Avg:  5m 21s | Max:  5m 21s
  🟩 90a                Pass: 100%/1   | Total:  2m 23s | Avg:  2m 23s | Max:  2m 23s
🟩 std
  🟩 17                 Pass: 100%/28  | Total:  1h 48m | Avg:  3m 53s | Max: 13m 37s
  🟩 20                 Pass: 100%/24  | Total:  1h 55m | Avg:  4m 49s | Max: 13m 27s | Hits:  83%/214

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
pycuda
CUDA C Core Library

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
pycuda
CUDA C Core Library

🏃‍ Runner counts (total jobs: 52)
# Runner
41 linux-amd64-cpu16
5 linux-amd64-gpu-v100-latest-1
4 linux-arm64-cpu16
2 windows-amd64-cpu16

@miscco miscco merged commit 8b2bf13 into NVIDIA:main Sep 19, 2024
66 checks passed
@miscco miscco deleted the any_resource_constructor branch September 19, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pciolkosz pciolkosz pciolkosz approved these changes

@alliepiper alliepiper Awaiting requested review from alliepiper alliepiper is a code owner automatically assigned from NVIDIA/cccl-cmake-codeowners

@gonidelis gonidelis Awaiting requested review from gonidelis gonidelis is a code owner automatically assigned from NVIDIA/cccl-codeowners

@ericniebler ericniebler Awaiting requested review from ericniebler

Assignees
No one assigned
Labels
CUDA Next Feature intended for the Cuda Next experimental library feature request New feature or request.
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miscco @alliepiper @pciolkosz