-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement make_integer_sequence
in terms of intrinsics whenever possible
#2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__make_integer_seq
intrinsic on MSVC when availablemake_integer_sequence
in terms of intrinsics whenever possible
🟨 CI finished in 9h 44m: Pass: 99%/417 | Total: 4d 13h | Avg: 15m 47s | Max: 1h 21m | Hits: 17%/41522
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 417)
# | Runner |
---|---|
304 | linux-amd64-cpu16 |
62 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
23 | windows-amd64-cpu16 |
🟩 CI finished in 19h 06m: Pass: 100%/417 | Total: 4d 13h | Avg: 15m 46s | Max: 1h 21m | Hits: 17%/41522
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 417)
# | Runner |
---|---|
304 | linux-amd64-cpu16 |
62 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
23 | windows-amd64-cpu16 |
miscco
approved these changes
Sep 9, 2024
Comment on lines
+48
to
+49
#elif defined(_LIBCUDACXX_HAS_INTEGER_PACK) // ^^^ _LIBCUDACXX_HAS_MAKE_INTEGER_SEQ ^^^ | ||
// vvv _LIBCUDACXX_HAS_INTEGER_PACK vvv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conventionally, we do not add those to elif branches, because it is clear what is coming next.
It is a bit inconsistent insofar we do not know what was before and I am open to suggestion whether we want to completely skip it or add a // ^^^ What is above ^^^ comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MSVC has the
__make_integer_seq
intrinsic, but our implementation ofmake_integer_sequence
isn't using it. this PR corrects that.additionally, it uses the
__integer_pack
intrinsic on gcc.fixes #2367
this PR defines
_LIBCUDACXX_HAS_MAKE_INTEGER_SEQ
when_CCCL_MSVC_VERSION_FULL >= 190023918
istrue
.it also conditionally implements
make_integer_sequence
in terms of__integer_pack
if such a builtin is available.Checklist