Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a nvrtc configuration for libcu++ #202

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Jul 11, 2023

We also want to test with nvrtc.

The main problem is that we only ever want to test with a single configuration and neither cub and thrust.

For that I went with a new build job that should exclude all unwanted configurations

Fixes #141

@miscco miscco added feature request New feature or request. infrastructure Shared CMake, github, etc infrastructure labels Jul 11, 2023
@miscco miscco requested a review from jrhemstad July 11, 2023 16:27
@miscco miscco self-assigned this Jul 11, 2023
@miscco miscco requested review from a team as code owners July 21, 2023 10:54
@miscco miscco requested review from elstehle and removed request for a team July 21, 2023 10:54
@miscco miscco force-pushed the build_nvrtc branch 13 times, most recently from 4e21472 to a28218a Compare July 21, 2023 16:34
@miscco
Copy link
Contributor Author

miscco commented Jul 21, 2023

The images are currently still running 12.0 drivers, so this PR is currently blocked until we get those images upgraded, presumably after the 23.08 release of rapids

@miscco miscco added the blocked This PR cannot be merged due to various reasons label Jul 21, 2023
@miscco miscco requested a review from jrhemstad July 21, 2023 17:38
@griwes griwes force-pushed the build_nvrtc branch 2 times, most recently from 4cf2dba to 2fac36b Compare July 28, 2023 03:16
@griwes griwes linked an issue Jul 28, 2023 that may be closed by this pull request
@griwes griwes requested a review from wmaxey July 28, 2023 04:40
@griwes griwes removed the blocked This PR cannot be merged due to various reasons label Jul 28, 2023
@wmaxey
Copy link
Member

wmaxey commented Aug 8, 2023

Can merge after conflict resolution, the changes look good.

Copy link
Collaborator

@jrhemstad jrhemstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to hold off on merging this until I reconcile the new matrix format.

Copy link
Collaborator

@jrhemstad jrhemstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good to go now.

The nvrtc configuration runs outside of our usual test matrix as we only ever test against the latest CTK and do not care about the host compiler.

Also currently there are only libcu++ tests running

Co-authored-by: Jake Hemstad <[email protected]>
Co-authored-by: Michał 'Griwes' Dominiak <[email protected]>
@miscco
Copy link
Contributor Author

miscco commented Aug 16, 2023

@jrhemstad I have squashed and rebased the commits as there have been some merge conflicts. Could you have a final look?

I assume we also want this for 2.2?

@jrhemstad
Copy link
Collaborator

I assume we also want this for 2.2?

Since this is all just infrastructure and doesn't impact user code, I don't think it is important to get it into the 2.2 release.

@jrhemstad jrhemstad merged commit e459eeb into NVIDIA:main Aug 16, 2023
@miscco miscco deleted the build_nvrtc branch August 17, 2023 07:22
alliepiper pushed a commit to alliepiper/cccl that referenced this pull request Aug 30, 2023
The nvrtc configuration runs outside of our usual test matrix as we only ever test against the latest CTK and do not care about the host compiler.

Also currently there are only libcu++ tests running

Co-authored-by: Jake Hemstad <[email protected]>
Co-authored-by: Michał 'Griwes' Dominiak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request. infrastructure Shared CMake, github, etc infrastructure
Projects
Archived in project
4 participants