-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a nvrtc configuration for libcu++ #202
Conversation
4e21472
to
a28218a
Compare
The images are currently still running 12.0 drivers, so this PR is currently blocked until we get those images upgraded, presumably after the 23.08 release of rapids |
4cf2dba
to
2fac36b
Compare
Can merge after conflict resolution, the changes look good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll want to hold off on merging this until I reconcile the new matrix format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be good to go now.
The nvrtc configuration runs outside of our usual test matrix as we only ever test against the latest CTK and do not care about the host compiler. Also currently there are only libcu++ tests running Co-authored-by: Jake Hemstad <[email protected]> Co-authored-by: Michał 'Griwes' Dominiak <[email protected]>
@jrhemstad I have squashed and rebased the commits as there have been some merge conflicts. Could you have a final look? I assume we also want this for 2.2? |
Since this is all just infrastructure and doesn't impact user code, I don't think it is important to get it into the 2.2 release. |
The nvrtc configuration runs outside of our usual test matrix as we only ever test against the latest CTK and do not care about the host compiler. Also currently there are only libcu++ tests running Co-authored-by: Jake Hemstad <[email protected]> Co-authored-by: Michał 'Griwes' Dominiak <[email protected]>
We also want to test with nvrtc.
The main problem is that we only ever want to test with a single configuration and neither cub and thrust.
For that I went with a new build job that should exclude all unwanted configurations
Fixes #141