Add a nvrtc configuration for libcu++ #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
added
feature request
jrhemstad
reviewed
Jul 11, 2023
jrhemstad
reviewed
Jul 11, 2023
jrhemstad
reviewed
Jul 11, 2023
jrhemstad
reviewed
Jul 11, 2023
2 tasks
miscco
force-pushed
the
build_nvrtc
branch
13 times, most recently
from
4e21472 to
a28218a
Compare
|
The images are currently still running 12.0 drivers, so this PR is currently blocked until we get those images upgraded, presumably after the 23.08 release of rapids |
griwes
force-pushed
the
build_nvrtc
branch
2 times, most recently
from
4cf2dba to
2fac36b
Compare
wmaxey
approved these changes
Aug 8, 2023
|
Can merge after conflict resolution, the changes look good. |
jrhemstad
requested changes
Aug 8, 2023
jrhemstad
approved these changes
Aug 16, 2023
The nvrtc configuration runs outside of our usual test matrix as we only ever test against the latest CTK and do not care about the host compiler. Also currently there are only libcu++ tests running Co-authored-by: Jake Hemstad <[email protected]> Co-authored-by: Michał 'Griwes' Dominiak <[email protected]>
|
@jrhemstad I have squashed and rebased the commits as there have been some merge conflicts. Could you have a final look? I assume we also want this for 2.2? |
Since this is all just infrastructure and doesn't impact user code, I don't think it is important to get it into the 2.2 release. |
jrhemstad
approved these changes
Aug 16, 2023
alliepiper
pushed a commit
to alliepiper/cccl
that referenced
this pull request
Aug 30, 2023
The nvrtc configuration runs outside of our usual test matrix as we only ever test against the latest CTK and do not care about the host compiler. Also currently there are only libcu++ tests running Co-authored-by: Jake Hemstad <[email protected]> Co-authored-by: Michał 'Griwes' Dominiak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also want to test with nvrtc.
The main problem is that we only ever want to test with a single configuration and neither cub and thrust.
For that I went with a new build job that should exclude all unwanted configurations
Fixes #141